Yii2: Add the ability to not render empty row in GridView when dataProvider does not have any data

[dkhlystov]

What steps will reproduce the problem?

<?= \yii\grid\GridView::widget([
    'dataProvider' => new \yii\data\ArrayDataProvider([
        'allModels' => [],
    ]),
    'showHeader' => false,
    'emptyText' => false,
]) ?>

What is the expected result?

<table><tbody></tbody></table>

What do you get instead?

<table><tbody><tr><td colspan="0"><div class="empty"></div></td></tr></tbody></table>

Additional info

| Q | A
| ---------------- | ---
| Yii version | 2.0.10
| PHP version |5.6
| Operating system |xubuntu 16.04

[developeruz]

Is it solve your problem?

<?= \yii\grid\GridView::widget([
    'dataProvider' => new \yii\data\ArrayDataProvider([
        'allModels' => [],
    ]),
       'showOnEmpty' => false,
    'emptyText' => '<table><tbody></tbody></table>',
]) ?>

[dkhlystov]

I got <div class="empty"><table><tbody></tbody></table></div>
And the GridView::$layout has not been used for rendering.

Thank you for the idea, but the solution is more like a crutch.

Where do I want to use it

[samdark]

How would you solve it?

[dkhlystov]

In this place I would like to add something like

if ($this->emptyText === false)
    return "<tbody>\n</tbody>";

[dkhlystov]

or add an additional condition here if (empty($rows) && $this->emptyText !== false) {

[samdark]

Additional condition solution sounds good to me.

[SilverFire]

@dkhlystov would you like to submit a PR?

[dkhlystov]

What do you mean? What is PR?

[SilverFire]

PR is a pull request.

We have a Git workflow for Yii 2 contributors, that will help you to do it for the first time

[dkhlystov]

This is to complicated for me.

[samdark]

Then either core team or community will handle it later. Thanks for idea.

[newerton]

https://github.com/kartik-v/yii2-grid/issues/800