Yetiforcecrm: [BUG] Sharing privileges

[iRainSystem]

There are 3 user
Each has its own role
The module has the right Privat (Software configuration> Permissions> Module access)
But custom rules are not appointed
Watch a video

[vovpff]

@iRainSystem I checked this too with new Logistic user. I can't see any records what assigned for different roles or different users with same role.
This is new rule

This from demo user

This is from log2 user

[vovpff]

@iRainSystem for this rule:

I can see all record in list

but detailed view available for only record what assigned to log2 user. All another records:

#0 /home/gitdevelop/domains/gitdeveloper.yetiforce.com/public_html/include/main/WebUI.php(70): Vtiger_Detail_View->checkPermission(Object(Vtiger_Request))
#1 /home/gitdevelop/domains/gitdeveloper.yetiforce.com/public_html/include/main/WebUI.php(205): Vtiger_WebUI->triggerCheckPermission(Object(Vtiger_Detail_View), Object(Vtiger_Request))
#2 /home/gitdevelop/domains/gitdeveloper.yetiforce.com/public_html/index.php(24): Vtiger_WebUI->process(Object(Vtiger_Request))
#3 {main}

[iRainSystem]

@vovpff
This is a bug? Or need to use the other buttons? what kind?

[vovpff]

@iRainSystem I think previlegues system are broken. I think fresh installation of system needed to check this but but no free time for this.

[iRainSystem]

@vovpff
Well I'll try to check it local host. And write results.

[vovpff]

@iRainSystem i checked at dev. 3.1.1089. The same situation. If you wanna try one more time: passwords for users qwe1 and qwe2 is 123456Aa

[iRainSystem]

@vovpff
i checked at 3.2 version installed on the local host. The same situation. :( I'm sad. it's bug.
all as in the first message.

[nic86]

check user_privileges/shared_privileges files
restart web service for refresh cache
maybe it can affect the new cron privilegesupdater

[iRainSystem]

@nic86
checked, does not work
I did a clean install from last version in develop branch (v3.2.0)

[iRainSystem]

@nic86
how i see file sharing_privilegesX.php - correct
....
$Vendors_share_read_permission=['ROLE'=>['H14'=>[6,],],'GROUP'=>[6=>[0=>6,],]]; $Vendors_share_write_permission=['ROLE'=>['H14'=>[6,],],'GROUP'=>[6=>[0=>6,],]];

[nic86]

then you need to analyze log php:
set 'LOG4PHP_DEBUG' => true, in config/debug.php
restart webservice
navigate to the page that not show the shared record
and analyze cache/logs/system.log

[iRainSystem]

@nic86
I have file, but I don't understand, no query for tables: vtiger_datashare_rs2rs vtiger_datashare_role2role vtiger_datashare_us2us
it's all right?
I can send a log.
after install my branch this: 3.2 clean install branch
system.log.zip

[nic86]

this is the query that generate list view:

SELECT vtiger_vendor.vendorname, vtiger_vendor.phone, vtiger_vendor.email, vtiger_vendor.category, vtiger_crmentity.smownerid, vtiger_vendor.vendorid FROM vtiger_vendor INNER JOIN vtiger_crmentity ON vtiger_vendor.vendorid = vtiger_crmentity.crmid WHERE vtiger_crmentity.deleted=0 AND (( vtiger_crmentity.smownerid = '5' OR vtiger_crmentity.smownerid IN (SELECT vtiger_user2role.userid AS userid FROM vtiger_user2role INNER JOIN vtiger_users ON vtiger_users.id=vtiger_user2role.userid INNER JOIN vtiger_role ON vtiger_role.roleid=vtiger_user2role.roleid WHERE vtiger_role.parentrole like 'H1::H2::H10::%')) OR (vtiger_crmentity.crmid IN (SELECT DISTINCT crmid FROM u_yf_crmentity_showners WHERE userid IN (5)))) LIMIT 0,21

in this table should be the users with shared owner: u_yf_crmentity_showners

the class should write to that table is located in this file : modules/Users/models/Privileges.php

you should do the debugging ( activating display_errors in .htaccess ) using the var_dump(variable name) followed by exit within the code or even better with xdebug

eg:
echo var_dump($privileges); exit;

[nic86]

sorry this is the shared owner not shared privileges.
shared privileges are in include/CRMEntity.php
function getUserAccessConditionsQuery
and
function getUserAccessConditionsQuerySR

[iRainSystem]

@nic86
You are the BEST!!!!

Look here:

if (isset($sharingPrivileges[$moduleName])) {
$sharingPrivilegesModule = $sharingPrivileges[$moduleName];

must be

if (isset($sharingPrivileges['permission'][$moduleName])) {
$sharingPrivilegesModule = $sharingPrivileges['permission'][$moduleName];

%)))))

[mariuszkrzaczkowski]

https://github.com/YetiForceCompany/YetiForceCRM/commit/a3cd28331fc328a547c3acde3f88512662db6a66