Yay: Long delay after pacman sync

[JojiiOfficial]

Version: Latest git commit (next branch)

Introduced with this commit the functions GetRemotePackages and GetPackageNamesBySource (inside pkg/query/filter.go) take almost precisely 5s to finish on my machine, which leads to a total delay of around 10s after syncing the databases here. I can't tell exactly if this is only a bug on my machine or a general bug but since there is no issue for it I created this one.

This commit was added after v10.0.4, which means v10.0.4 (all commits added before the linked one above) are unaffected of this bug under the same circumstances (same installation, same packages, etc...).

[Jguer]

I believe it's one place where find satisifiers is used where a direct get was used before. I just need to find it...

[John-Gee]

I confirm the issue on my computers and someone else's, so it's definitely not just you.

[mindyourlifeguide]

Confirm issue.

[AtifChy]

confirm issue

[alexgantera]

confirm issue

[atreyasha]

Confirm issue

[binex-dsk]

Confirm issue. Is only around 3s for me though, and on my server it's just 1-2s oddly.

[stonespheres]

Confirm issue, very long wait here.

[mixedCase]

Hey everyone, the issue already has a Status: Confirmed label (now In progress), no need to further confirm.

[Jguer]

@JojiiOfficial this issue should be fixed on yay-git as of https://github.com/Jguer/yay/commit/8d9fed2ad02942ddd3ad8e06146e2cfaa537c313 can you confirm?

[jonpas]

I can confirm, nice work!

[JojiiOfficial]

Works for me too. Good Job!

[Morganamilo]

Yeah, Dbs are actual hashmaps. and using .pkg() on a db does a quick lookup. You really don't wanna try to find packages by iteration.

[Jguer]

Yeah, Dbs are actual hashmaps. and using .pkg() on a db does a quick lookup. You really don't wanna try to find packages by iteration.

yeah, I think we had that loop for something else and it ended up going into the Executor as the remote packages implementation by distraction.

I'm tagging a release to get this closed