Yaru: Snap store category icons are incomplete

[Feichtmeier]

Snap store has much more categories than gnome software.
We are missing many of the icons, even if it's only a missing symlink.

These are the categories we provide: https://github.com/ubuntu/yaru/tree/master/icons/Suru/scalable/categories

@kenvandine could you give us a list of the category icon names you look up? Then we can make them completely yaru styled.
Thanks in advance ! :)

[kenvandine]

Snap store has much more categories than gnome software.
We are missing many of the icons, even if it's only a missing symlink.

These are the categories we provide: https://github.com/ubuntu/yaru/tree/master/icons/Suru/scalable/categories

@kenvandine could you give us a list of the category icon names you look up? Then we can make them completely yaru styled.
Thanks in advance ! :)

https://gitlab.gnome.org/Community/Ubuntu/gnome-software/-/blob/snap-store-packagekit/plugins/snap/gs-plugin-snap.c#L166

Line 166 through 240

[meetdilip]

So it will be

1. Games
2. Finance
3. Development
4. Social
5. Music and Audio
6. Productivity
7. Utilities
8. Photo and Video
9. Sever and Cloud
10. Arts and Design
11. Books and Reference
12. Devices and IoT
13. Education
14. Entertainment
15. Health and Fitness
16. News and Weather
17. Personalisation
18. Science
19. Security

Are these supposed to be full-colour Yaru style or Symbolic ?

[meetdilip]

If it is something like this, it is easy to make

[Feichtmeier]

Symbolic only @meetdilip
Thanks for the list ! :beer:

[meetdilip]

I used a Yaru template. In case that makes any difference

Posted at the same time :)

[meetdilip]

Does this count as symbolic ?

[meetdilip]

How about using this as a template for Snap Store category icons ? We can fit in indications inside that circle. Easy to align and mixes with other elements in the snap store window

[meetdilip]

Tried the full set. I had to use some icons from Material Design and others

(EDIT: Sorry @meetdilip, I accidentally edited this instead of replying! I've put it back again. @ubuntujaggers.)

[Feichtmeier]

@meetdilip thanks for the idea - let's see what @ubuntujaggers could use as an inspiration here :+1:

@ubuntujaggers this is the current snap store with gtk-common-themes from edge - so I think it should be the yaru master from after 19.10 (old gtk theme, but category icons look like what we have in master):

---

• [x] Games: applications-games-symbolic
  

• [x] Finance: accessories-calculator-symbolic
  

• [x] Development: applications-engineering-symbolic
  

• [x] Social: user-available-symbolic
  

• [x] Music and Audio: folder-music-symbolic
  

• [x] Productivity: text-editor-symbolic
  
  (this category is doubled :thinking: @kenvandine )

• [x] Utilities: applications-utilities-symbolic
  

• [x] Photo and Video: applications-multimedia-symbolic
  

• [x] Server and Cloud: network-server-symbolic
  

• [x] Art and Design: applications-graphics-symbolic
  

• [x] Books and Reference: accessories-dictionary-symbolic
  

• [x] Devices and IoT: application-x-appliance-symbolic
  

• [x] Education: document-page-setup
  
  @kenvandine I guess it misses the "-symbolic" suffix but see comment below

• [x] Education & Science: @kenvandine we have an icon for this, but it does not show up in your snap-store list, and it is the wrong icon- upstream too, should not be a "?"
  

• [x] Entertainment: applications-multimedia-symbolic
  

• [x] Health and Fitness: NULL (@kenvandine we would need an icon name here)
  

• [x] News and Weather: weather-clear-symbolic
  

• [x] Personalisation: preferences-desktop-wallpaper-symbolic
  

• [x] Science: applications-science-symbolic
  

• [x] Security: security-high-symbolic
  

Categories not in your C file, I guess because they are sucked from gnome-software? @kenvandine
But here we have Yaru icons anyways, so not on the to-do list

[meetdilip]

Photo & Video and Entertainment has the same icons.

Not criticising, but a camera icon for Art& Design ?

Communication & News has a similar icon as Social.

Apart from these very minor things, great work.

[Feichtmeier]

Let's keep this issue as clean as possible to get it done until 20.04
List is there, now we need pull requests for Books and Reference: accessories-dictionary-symbolic 👍

[ubuntujaggers]

Not criticising, but a camera icon for Art& Design ?

Fair challenge - that design made more sense in Gnome Software, because the category there is called Graphics & Photography. However, the same symbol turns up in Snap Store where "Photography" isn't mentioned :) From this, I learned the danger of swapping out the metaphor that upstream uses (because another app might choose the same symbol based on how it looks upstream).

The good news is I improved this a while ago in Master, as you can see in the latest Gnome Software:

...and I guess we just have to wait for the "common themes" version of Yaru to update before we see the change in Snap Store?

[Feichtmeier]

@kenvandine alrighty, Stuart added

But now you need to make sure to use the "-symbolic" suffix for your education category :smiley_cat:

[Feichtmeier]

Apart from some icons still missing from either wrong icon names in the snap-store C file or from our side with missing icons...
is it really needed to expose so many categories to the user @kenvandine ?
Many categories are also doubled and or almost the same.

[kenvandine]

That's defined by the store. We would need to redesign how the categories are selected to change that. Which I would be interested in doing, just not going to happen in the near term.

[Feichtmeier]

Okay, thanks for the reply @kenvandine :+1:

About the health categories: any idea how we could name this icon?
https://gitlab.gnome.org/Community/Ubuntu/gnome-software/-/blob/snap-store/plugins/snap/gs-plugin-snap.c#L224
Eventually applications-health-symbolic ? :thinking:

[kenvandine]

I don't have an opinion on the name. This is blazing new paths, so I'll
use whatever name you would like to provide in the theme.

On Fri, Mar 6, 2020 at 11:34 AM Feichtmeier [e-mail]
wrote:

Okay, thanks for the reply @kenvandine https://github.com/kenvandine 👍

About the health categories: any idea how we could name this icon?

https://gitlab.gnome.org/Community/Ubuntu/gnome-software/-/blob/snap-store-packagekit/plugins/snap/gs-plugin-snap.c#L224
Eventually applications-health-symbolic ? 🤔

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ubuntu/yaru/issues/2001?email_source=notifications&email_token=AAANMBKR3J7VJIS6LLJNE3TRGDGTPA5CNFSM4K47Y5BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOA4MJI#issuecomment-595707429,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAANMBKH4AVGNCCBWEOQVI3RGDGTPANCNFSM4K47Y5BA
.

--
Ubuntu - "I am what I am because of who we all are"

[Feichtmeier]

@ubuntujaggers

you think this would be okay for applications-health-symbolic?

[meetdilip]

Sorry to crash in. I saw the file for health and fitness icon as

icon = NULL; // FIXME: needs a better icon

I have a couple of suggestions. For symbolic, we could simply use a grey scale version or even drop the fill

[Feichtmeier]

@kenvandine alrighty, it's going to be applications-health then :+1:
The rest of the icons is actually already in yaru, there is just something missing in gtk-common-themes here, we / I need to investigate what's actually happening. With snap-store from edge and adwaita everything is fine, except the Health icon

[Feichtmeier]

@kenvandine applications-health is in yaru master now
so you could use it for the health and fitness category :+1:

Closing the issue here since the list is complete from our side