Yaru: Gtk3: color picker button stretches the headerbar

Created on 9 Feb 2020  ·  5Comments  ·  Source: ubuntu/yaru

Prbly because it misses the button padding metrics from the top of common :|
Yeah as I said you can put EVERYTHING in the headerbar. And gtk app devs just look for the default paddings of adwaita and apply this

image

Clicking on the list opens this stack ->

image

Peek 2020-02-09 12-06

gtk3

Most helpful comment

Peek 2020-02-09 12-06

@madsrh
No, the headerbar should not change it's sizes. So the padding of all potential elements must fit the height. We managed to make this happen for mos things. But it looks like we've missed the color picker buttons

@clobrano the button looks thinner because the height gets stretched :)

All 5 comments

Isn't it supposed to look like that? :thinking:

Do you mean the option button is thinner?

Peek 2020-02-09 12-06

@madsrh
No, the headerbar should not change it's sizes. So the padding of all potential elements must fit the height. We managed to make this happen for mos things. But it looks like we've missed the color picker buttons

@clobrano the button looks thinner because the height gets stretched :)

Ahhhhh sorry, I missed that in the screenshots but it's easy to see in the gif. I thought you meant that the button was a rectangle aka stretched in the headerbar 🤦‍♂ (too early for me 😄 )

Note: it turned out that this is actually an upstream inconsistency since the min height is not set, should fix this upstream

Was this page helpful?
0 / 5 - 0 ratings

Related issues

sicklylife-jp picture sicklylife-jp  ·  3Comments

CDrummond picture CDrummond  ·  3Comments

matthewpaulthomas picture matthewpaulthomas  ·  3Comments

matthewpaulthomas picture matthewpaulthomas  ·  3Comments

chrisjbillington picture chrisjbillington  ·  3Comments