Yaru: Dark menus have low contrast

[madsrh]

Could we change the background color of the menu here? It blends too much with the background IMO. I know there's a "_Menu borders in the dark theme are not strong enough_" item on the TODO list, but a background color tweaking wouldn't hurt.

[Feichtmeier]

Yup there is a menu color in colors - np
Also the border is not dark enough

[Feichtmeier]

Another image for a "proof"

[Feichtmeier]

@madsrh
is this already an improvement?

[madsrh]

is this already an improvement?

Yes, for sure, but why be subtle? 🙈

What do you think about using the same brightness as the label in the lower right corner?

Or darker, like the headerbar? I know that menus should be lighter, but just trying something with highter contrast.

Too much?

[Feichtmeier]

I guess the brighter one is somehow consistent with the light theme (becomes brighter)
Okay what about this:

I can't make it exactly like the $bg_color otherwise it drowns elsewhere
(this is another example: you can't just pick one place - there are the weirdest gtk apps that take this widget in this box and that widget in that box and so on)
(In Nautilus we swapped the colors... what is $base_color in adwaita is $bg_color in yaru ... )
Edit: here is a check for settings... the rows use $base_color, the buttons use a lightened $bg_color and now the menu is different from both (which is good I think):

Menu popped up:

[madsrh]

I think that's much better than the first suggestion 👍

I'm guessing that it's deliberate that these borders are just ever so slightly different. #nitpicking

[Feichtmeier]

:man_shrugging:
Might be but that's all upstream code

About the menu/window borders in general: they are defined deep down in _common.scss for ALL window borders. So windows, menus, csd menus and so on.
They descent from the $borders_color but are double transparentized to avoid some bug (at least this is what someone from upstream wrote in common)

So if you are okay with it I would make a PR and then check also the checkbox from the big issue about the borders

Edit:

I'm guessing that it's deliberate that these borders are just ever so slightly different. #nitpicking

Yes thats a different border ....

[madsrh]

Perfect