Yaru: Missing icons: checkmark and close-X action icons

Created on 2 Jan 2020  路  11Comments  路  Source: ubuntu/yaru

In the Ubuntu installer (ubiquity-frontend-gtk) there are green checkmarks showing up if you filled a field successfully :heavy_check_mark:
Those are still taken from the Humanity icon theme and could use an update

Screenshot from 2020-01-02 12-44-28

It looks like two symlinks are also needed. As a bonus the X-icons could also be updated
image

The list could be:

Positive checkmarks:

  • [x] dialog-apply (THIS is the icon, the rest are "only" symlinks)
  • [x] dialog-yes
  • [x] dialog-ok
  • [x] gtk-ok
  • [x] gtk-yes
  • [x] stock_calc-accept
  • [x] stock_mark
  • [x] stock_mail-filters-apply
  • [x] stock_yes

Negative cancel X icons

  • [x] window-close (THIS is the icon, the rest are "only" symlinks)
  • [x] cancel
  • [x] dialog-close
  • [x] dialog-no
  • [x] dialog-cancel
  • [x] button_cancel (with _ not -)
  • [x] gtk-close
  • [x] stock_calc-cancel
  • [x] stock_close

@ubuntujaggers and/or @madsrh please have a look in /usr/share/icons/Humanity/actions

icon theme

Most helpful comment

Thinking about it: if we have a lot of green ticks and red X's that are symlinked, the origin file shouldn't be the Dropbox ones because those icons are too app-specific. As it happens the two Dropbox emblems are currently very generic so it works but we might change things later (e.g. if Dropbox develops its own widely-understood glyphs). So, IMO best practice would be:

  • Clone the (lovely) Dropbox emblems to make icons for dialog-apply and window-close, which will cascade through symlinks to the other use cases

  • Consider whether we want to make the Dropbox icons symlinks instead of having two identical icons in Yaru.

All 11 comments

Regarding the checkmark 鉁旓笍 there's two options:
image

or...

image

The second one is most in line with the Canonical design specs we will be discussing next week. Moving the checkmark inside the textfield isn't possible, right?
image

Moving the checkmark inside the textfield isn't possible, right?

I think not, it should be a widget feature, but afaik gtk entries don't have check image inside.

We could simply symlink to the emblem icons:
image

but perhaps these should also be revisited and updated with these? This green is #0e8420

https://assets.ubuntu.com/v1/5594880d-error.svg
https://assets.ubuntu.com/v1/94949185-icon-success.svg

Thinking about it: if we have a lot of green ticks and red X's that are symlinked, the origin file shouldn't be the Dropbox ones because those icons are too app-specific. As it happens the two Dropbox emblems are currently very generic so it works but we might change things later (e.g. if Dropbox develops its own widely-understood glyphs). So, IMO best practice would be:

  • Clone the (lovely) Dropbox emblems to make icons for dialog-apply and window-close, which will cascade through symlinks to the other use cases

  • Consider whether we want to make the Dropbox icons symlinks instead of having two identical icons in Yaru.

  • Clone the (lovely) Dropbox emblems to make icons for dialog-apply and window-close, which will cascade through symlinks to the other use cases

Doing a branch for this now :)

Doing a branch for this now :)

We might want to base this on the Canonical design. Which is slightly different and slightly darker. See the links above

EDIT: But it's a good point not to use Dropbox.

Should we wait till after design fest then?

Should we wait till after design fest then?

Well, it's just the two icons so we can always change this later

Well, it's just the two icons so we can always change this later

:+1: And all the folders/symlinks will still be made and work :)

Also missing is the view-refresh.svg and it's symlinks

image

It looks like we've missed one symlink
image

Was this page helpful?
0 / 5 - 0 ratings

Related issues

pojntfx picture pojntfx  路  3Comments

mivoligo picture mivoligo  路  3Comments

Feichtmeier picture Feichtmeier  路  3Comments

matthewpaulthomas picture matthewpaulthomas  路  3Comments

Feichtmeier picture Feichtmeier  路  3Comments