Yaru: Heavy Text-Shadows in app-notifications and gnome-shell notifications

[Amr-Ibra]

Two ways to reproduce the issue:

Option 1.
Delete a file in Nautilus and look at the font in the in-app notification, that the font is blurry

Option 2.
Insert a USB stick, point the mouse to the shell notification and look at the font in the button "Open with Files", the font is blurry

$ snap info communitheme
snap-id: Yd6CISPIf6tEf3ZEJ0cqSoEg9rG2VkRi
tracking: edge
refresh-date: 12 days ago, at 13:34 CET
channels:
stable: 0.1 2019-03-13 (1768) 16MB -
candidate: ↑
beta: ↑
edge: 29.171 2019-12-01 (1893) 18MB -
installed: 29.171 (1893) 18MB -

[Feichtmeier]

Indeed thanks - forgot to fix this.

1) is the .osd styling which we dont overrwrite in our app notifications in tweaks, settings text-shadow to none should be enough
https://github.com/ubuntu/yaru/blob/master/gtk/src/default/gtk-3.20/_tweaks.scss#L135
Upstream app-notifcations use the osd styling:
https://github.com/ubuntu/yaru/blob/master/gtk/src/default/gtk-3.20/_common.scss#L3816
-->
which have a very heavy text and icon shadow:
https://github.com/ubuntu/yaru/blob/master/gtk/src/default/gtk-3.20/_common.scss#L240

2) is the hotplug notification in the shell - could be caused by the inherit color, this is an upstream issue as we did not change this part (they just didnt see it because they dont use the light shell yet)
https://github.com/ubuntu/yaru/blob/master/gnome-shell/src/gnome-shell-sass/_common.scss#L1751

[clobrano]

is the hotplug notification in the shell - could be caused by the inherit color, this is an upstream issue as we did not change this part (they just didnt see it because they dont use the light shell yet)

This is also "nice to have" in our dark variant. So any change must be done either upstream or only for the light variant

[clobrano]

Sorry, I accidentally pushed on master the change on gtk osd

https://github.com/ubuntu/yaru/commit/1b1ef25dea8ea31b10379af7c5ad951111ff9f19

could you double check the gtk side of the issue is fixed? Thanks

[Feichtmeier]

I think he can't because he uses bionic. Could you make a bionic PR for a test snap? :innocent:

[clobrano]

Ok

[clobrano]

please test this on bionic #1675

[Amr-Ibra]

Yes, it's fixed now in nautilus app-notification.

[clobrano]

closed by #1675

[Amr-Ibra]

Please apply the fix to Bionic. I'm using the snap version: 29.179 2020-01-16 (1949), and the fix is not there yet.