Yaru: Add proper style for selected text in Evince

[clobrano]

see https://gitlab.gnome.org/GNOME/evince/issues/1043 for more information

important extract from the link above

Having said that, have you tried adding Evince support in Yaru itself? After looking at Yaru source, I think the following should work (not tested):

/* Override Evince text selection */
evview.content-view:selected {
  @extend %selected_text;
}

[monday15]

/* Override Evince text selection */
evview.content-view:selected {
  @extend %selected_text;
}

This stuff should not work. Application css styles has higher priority than theme styles, so this code will change selection background to @theme_selected_bg_color anyway.

[clobrano]

Thanks @monday15, that's right indeed. I'll report it back to Evince repo

On Mon, 31 Dec 2018 at 07:54, monday15 [e-mail] wrote:

/* Override Evince text selection */
evview.content-view:selected {
@extend %selected_text;
}

This stuff should not work. Application css styles has higher priority
than theme styles, so this code
https://gitlab.gnome.org/GNOME/evince/blob/master/shell/evince.css#L23-25
will change selection background to @theme_selected_bg_color anyway.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ubuntu/yaru/issues/1069#issuecomment-450613994, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACwAHrhGatvtLUVJBgGPktzDDOfJziS3ks5u-bSlgaJpZM4ZlEol
.

[clobrano]

I rebuild Evince without the css part underlined by @monday15, and the result is bad as well

what is most important is that Adwaita results to be broken as well. In the end, we might need to consider a comeback to orange as text selection color, since it is working only in Gedit so far

@madsrh , @Feichtmeier

[Feichtmeier]

Oh what a nice idea to double check that!
Yes it's a mess. Only entries, textview and chrome work. Firefox, libre office, evince don't work
I think gtk is currently not really supporting different selection colours

[madsrh]

@clobrano I think it's a good decision after all this trouble - what a journey!

[clobrano]

closing this since it is not technically possible right now