Yaru: Treeview header misses a border-top

[Feichtmeier]

@clobrano do you know why we never added a border here? For example because it would cause a double border in some circumstances or something like that?

I think it would look more complete with a border-top

It's here: https://github.com/ubuntu/yaru/blob/master/gtk/src/light/gtk-3.20/_common.scss#L2216

[Paz-it]

because it would cause a double border in some circumstances or something like that?

YES! that's exactly the reason.

[Feichtmeier]

@Paz-it could you show me an example app?
I think no border looks far more broken than a double border :man_shrugging:

[Paz-it]

Open widget factory and see for yourself. in most apps it is having the header bar border on top
or the border of the window it seats on top of it.

[clobrano]

In fact, in widget factory all the treeview headers have a top border, however even Nautilus doesn't have it

EDIT: but adding the top border would break the effect of the tab being a whole pane

[Feichtmeier]

They "have" only a top border when the table is put in a container which has a border itself but it's not their border, it's the border of the container

[clobrano]

Yes of course, however if you add a proper top-border, this would be doubled when in a container, unless we can avoid that

[Feichtmeier]

If you two guys think it's not an issue then I'm fine. However I think this looks very unusual. I think some might even think that something looks broken there because they don't know the reasoning. Especially when I look at the screenshot of the table inside the tab. It looks like - if UI elements where fluid - something could float into that opened border. :D
I think arc dodges this by adding a small margin to the left and right border of those header buttons, resulting in a look that is opened at all edges of the header buttons and no only on three sides

[clobrano]

I agree that doesn't look good this way. Adwaita I think does not have it, it just has a darker color above the treeview usually , which works as border. Probably I have a holder version of Arc, in 16.04 it looks this way

[clobrano]

This is how it looks adding a top-bar (not good either)

[Feichtmeier]

Ah never mind then. I don't know what's a less common: table in a tab or table without a box
Let's close this