Yaru: Remmina's popover menu items have no bg color change on hover

[godlyranchdressing]

Expected Behavior

The background color of menu items should darken when hovered on.

Actual Behavior

Background color doesn't change.

Steps to Reproduce the Problem

1. Open Remmina
2. Hover over an item in the popover menu

[Feichtmeier]

A very similar hierarchy can be found in gnome disks

But it is styled correctly here :thinking:
It is
button .popup.toggle

[godlyranchdressing]

@Feichtmeier Yeah. I've been trying to fix this every now and then but I have no idea what's the source of the issue. :man_shrugging:

[Feichtmeier]

Maybe it is due to our transparent hover color?
I think adwaita has an opaque hover bg, right? :thinking:

[monday15]

Remmina not happy about transition usage in menuitem.
https://github.com/nana-4/materia-theme/issues/300

[godlyranchdressing]

@monday15 So that's why. Thanks for your help. I guess this means we'll have to remove the transition for menu items. :disappointed:

@Feichtmeier what do you think? I know there's a newer version of Remmina that uses a headerbar, I wonder if it works fine there.

[Feichtmeier]

To be honest, I never realized that we have a transition there :0
I don't know I don't have a strong opinion on that, I'll pass that to @madsrh and @clobrano :D

[clobrano]

Let's see if it works first. If it does and the effect is minimal, I'd say we can go with that. Otherwise, we really want to drop a nice effect for only one application bug?

[godlyranchdressing]

@clobrano I tested it by removing the transition (line 2278) and Remmina works fine now. I am biased as I use Remmina fairly often with new projects and stuff, but with the transition being only slightly noticeable I'm leaning towards removing it.

[clobrano]

@godlyranchdressing, if the difference is minimal, I'd say it's ok to fix remmina

[antenore]

@godlyranchdressing this has been fixed in Remmina, if you want you can bring back the transition effect.

[clobrano]

@atenore, when will the version with the fix be released?

[antenore]

Already released upstream.. 1.3.2

[clobrano]

I installed 1.3.2 from PPA and reverted Yaru's workaround, but the problem seems still there...

[antenore]

@clobrano damn it's not what I've been told.
I'll investigate further.

[Feichtmeier]

Oh I copied the glade file like you mentioned on the gitlab and then reintroduced the menu transition to my local Yaru meson installation and the issue was not there, is there any difference between the current PPA code and the glade file you told me to use on the gitlab issue?

[antenore]

Normally not, I'll check.. It could be i screwed up with some commits.

[antenore]

@Feichtmeier , @clobrano I've verified and the glade file is correct, so if it doesn't work the issue is somewhere else, but I don't know how to fix it (yet).