Yaru: Authentication dialog title uses Adwaita styling

[godlyranchdressing]

Expected Behavior

Authentication dialog title color should be using the same font color and font weight as other dialog titles, see an example in the shutdown dialog. #3B3B3B font color, font weight isn't bold:

Actual Behavior

Authentication dialog titles look like they do in Adwaita: lighter font color, bold font. This is probably the fallback styling, unless you explictly define how something looks for the Shell, the element always falls back to Adwaita styling.

Steps to Reproduce the Problem

Open a program that requires authentication (gparted, etc.) or try to install a program from the software center

[clobrano]

I am not 100% sure, but in my system the authentication pop up looks Yaru-ish

[eaglersdeveloper]

I think the problem in header's color.

[eaglersdeveloper]

The shutdown dialog, on the contrary, doesn't looks in Yaru style.

[clobrano]

In my system, the shutdown dialog is like the one we have in the wiki

however, while taking screenshots something weird happened, the shutdown dialog changed from Yaru to Adwaita style and then 60 seconds after, the notebook shut down, even if I pressed cancel on the dialog, like the original one ( with the Yaru style) disappeared, but continued the count down.

It happened just once though

maybe @didrocks is interested in this last behavior

[eaglersdeveloper]

This is hardly related to the theme. This is the glitch of Shell.

[eaglersdeveloper]

I meant not only the background color, but header and button style.

In GTK's MessageDialog font weight of header is bold and button style different.

[clobrano]

This is hardly related to the theme. This is the glitch of Shell.

That's understood, this is why didrock might be interested.

However, if I got it right, the point of this ticket is not the difference
between our gtk and shell theme, which is wanted.

Il sab 27 ott 2018, 18:16 Eaglers [e-mail] ha scritto:

I meant not only the background color, but header and button style.

[image: 2018-10-27 09-09-21]
https://user-images.githubusercontent.com/40228953/47606462-ed513480-da24-11e8-93f7-6f226f18f3be.png

In GTK's MessageDialog font weight of header is bold and button style
different.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ubuntu/yaru/issues/937#issuecomment-433634013, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACwAHgEj40ltacGEwmpub0M5AhZjA4Wyks5upIbzgaJpZM4X8nbc
.

[eaglersdeveloper]

It turns out that the background color is different.
MessageDialog has a dazzling white background (#FFFFFF)
The Shell's dialog has an almost white background (#F4F4F4)

[eaglersdeveloper]

I will create an issue.

[clobrano]

Have you manage to reproduce this issue?

Il sab 27 ott 2018, 18:29 Eaglers [e-mail] ha scritto:

It turns out that the background color is different.
MessageDialog has a dazzling white background (#FFFFFF)
The Shell's dialog has an almost white background (#F4F4F4)

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ubuntu/yaru/issues/937#issuecomment-433634960, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACwAHjNxIlZRadXon29tDdZca5cz43wxks5upIoEgaJpZM4X8nbc
.

[eaglersdeveloper]

What did you do?

[godlyranchdressing]

It seems hardcoded. I did everything I could think of (to try making the title match the other dialog titles) and still nothing. There's no unused relevant class in polkitAgent.js either.

[clobrano]

Ok, the problem was also me reading the bug description on a small screen and missing that the subject was the dialog title. Sorry for the noise

[clobrano]

How does it look this way?

(below the auth dialog, there is a screenshot of shutdown dialog for comparison)

[godlyranchdressing]

That looks good. That's what I was trying to get it to look like. Is that a mockup though, or is that how it looks on your system? (I'm still on 3.28)

[clobrano]

It's the real system. I modified the .message-dialog-title class. I am
about to open a PR only with that, and another one for the background color

On Sun, 28 Oct 2018 at 16:03, Aaron Papin [e-mail] wrote:

That looks good. That's what I was trying to get it to look like. Is that
a mockup though, or is that how it looks on your system? (I'm still on 3.28)

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ubuntu/yaru/issues/937#issuecomment-433713450, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACwAHjDtXtVBEJr7zIWPd5iLiBZYZboZks5upccqgaJpZM4X8nbc
.