Yaru: Selected text is hardly readable in the dark theme

[Feichtmeier]

Because the text color of the darktheme is bright, the light blue makes selected text very hard to read in the dark theme:

First ideas:

A) $text_selection: if($variant == 'light',#C4E4F0, lighten($blue,10%));

B) $text_selection: if($variant == 'light',#C4E4F0, $blue);

@madsrh @luxamman @clobrano
Any other ideas?

[clobrano]

Test selection should be dark, it's a mistake from last PR

[madsrh]

[Feichtmeier]

Ah, okay changing text-color would be an option, too. So I change this locally in %selected_text, alrighty? Because globally wouldn't make much sense, because the global dark text color is light, and the global light text color is dark :O

%selected_text {
$c: $text_selection;
$tc: if($variant==light,$text_color,#2D2D2D);
background-color: $c;
color: $tc;

[Paz-it]

Or maybe :

Even better #3f3c40

[Feichtmeier]

Okeee. Talking about text-color. Light theme backdrop text color looks a bit weird, too:

Any preferences? @madsrh @clobrano

[madsrh]

@Feichtmeier well, it depends on if we still want to follow the overlay/multiply idea? Then it should become darker. Below I've made the text slightly lighter, but my first thought was the the background color should turn gray

[Paz-it]

For the light theme :

Agree with @madsrh but goes a bit lighter
IMO, the dark theme should not use blue.

[Feichtmeier]

@madsrh okee?

@clobrano I can't change it here:
$backdrop_selected_fg_color: ...
Because that changes many other stuff.
So I change it here, oke?
```
%selected_text {
$c: $text_selection;
$tc: if($variant==light,$text_color,#2D2D2D);
background-color: $c;
color: $tc;

&:disabled { color: mix($tc, $c, 50%); }

&:backdrop {
background-color: _backdrop_color($c);
color: $slate;//$backdrop_selected_fg_color;

&:disabled { color: mix($backdrop_selected_fg_color, $c, 30%); }

}
}

[madsrh]

@Feichtmeier I can't see that the blue selection color changes in the light version. Shouldn't it just a tiny tiny bit darker/lighter?

And the blue color in the dark version is IMO too much. A more subtle change would be good (also for the text).

[Feichtmeier]

[clobrano]

Sorry, I'll be afk for a couple of days

[madsrh]

Looks good.

I'm a little in doubt if the dark theme shouldn't become darker anyway 🤦‍♂️ Doesn't it steal too much focus currently in backdrop? 🤔

[Feichtmeier]

That's what I thought too! The dark theme does not work like the light theme!
Okay, so I could start off with the text backdrop and use other issues/PR for the rest of the backdrop?

[Feichtmeier]