Yaru: Keyboard focus for switches should span whole widget

[ya-d]

Currently only the "knob" is surrounded by the dotted orange line which is hardly visible and differs from other widgets. The selection ring should span the whole widget with some padding.

[clobrano]

If the ring is around the knob, it means it's the selected widget. Not sure we can "transfer" the selection to the whole switch. I need to investigate a bit more

[clobrano]

I double check and focus state is actually and correctly on the switch widget and not on the knob/slider.

Adwaita however does the same thing, so I think this is how this kind of widget show selection (actually the part on which you can act on when selected is the slider, so it is not so wrong as a meaning).

[ya-d]

Would it be possible to add an asymmetrical padding to achieve something like this?

[clobrano]

:thinking: I'll try!

[ya-d]

Argh. I just figured that the selection ring probably moves with the knob so this hack won't work for both on and off states. But even the one with symmetrical padding looks better to me and is more visible in any case.

[clobrano]

Uhm, right I didn't think at all myself. Theoretically we know in which state the knob is, but it's getting a bit complex. What about the same as the buttons and treeview row, selection ring slightly inside the knob?

[ya-d]

I would say its better than the selection ring being the border itself but might get a bit small. I tend to prefer the outer ring even if it crosses the switch. But thats only a personal preference.

[Paz-it]

Just a stupid question - Why do we need this ring anyway??!!??

[Feichtmeier]

It is the focus ring. Some people use the tab key to travel through the UI elements. The focus ring indicates were the focus is

[clobrano]

Unfortunately outline-offset property cannot be asymmetric, so the best we can have is this one

the thin line does not help, but bigger would be even worse

[Feichtmeier]

I'd prefer the current solution then which looks pretty logical to me. This one ∆ looks like something went wrong in my opinion

[ya-d]

Agreed. What about a very minor inset?

[clobrano]

Current

Changed