Yaru: Black background in some apps

[yawzub]

Gnome Videos, Gnome Photos, Gnome boxes are affected.

[clobrano]

Those application are designed to use a dark variation, it's not due to the theme

[yawzub]

@clobrano I'm talking about this #0b0b0d background. Is it intended?

Shouldn't it be something like this instead?

[clobrano]

oh I see now, thank you for reporting it :+1:

However, mine is correct

[yawzub]

@clobrano It turns black when you add something.

[Feichtmeier]

Is this really an issue? Adwaita uses the dark background, too:

I guess this is somehow "wanted" by the adwaita designers. So this would be a design question I guess? @madsrh

[madsrh]

Hmm, I'm not sure here. For reference I'll use Adwaita screenshots.

For the empty _(Stared photos will appear here)_ "Favorites" background we can leave this as it is or change it to match "Photos" background. I would say, leave it although it's currently a different color than the other views (photos/albums), but so is it in Adwaita.

This one is weird:

Three different background colors is too much. Let's change the #0b0b0d to black so we have one continuous background.

Photos:

To me, the "Photos" view looks really messy by design!
EDIT: I actually think the current very discreet border between photos is nice. My initial thought was to make the border match the background (black) as seen in the Arc, Pop and Numix themes.

[clobrano]

Hey @Feichtmeier, is this one fixed with your recent work on dark variant?

[Feichtmeier]

Well at least videos is "affected":

(Yeah that's my headbanging daughter)
But are you sure this should be changed? This way it looks like a real "movie" background. :man_shrugging:

[clobrano]

Double checked now, it looks like the last suggestion from @madsrh isn't implemented

EDIT: I actually think the current very discreet border between photos is nice. My initial thought was to make the border match the background (black) as seen in the Arc, Pop and Numix themes.

do you think this is possible?

[Feichtmeier]

.documents-scrolledwin.frame.frame widget flowboxchild.tile { background-color: transparent; }
@clobrano @madsrh
Fixed it for Photos. I think there is only that background in photos. Videos has no background (anymore)
I could make a PR for photos.

Or, if you want the border to have the same color:


.documents-scrolledwin {background-color: black;}

[Feichtmeier]

My personal fav would be transparent background:

[clobrano]

Thanks @Feichtmeier, I prefer transparent as well :+1:

[Feichtmeier]

Cool I just realized that gnome boxes is already fixed so photos is the only left