Yarn: Improper names from #200 prefix -> suffix move

Created on 27 Nov 2018  路  8Comments  路  Source: FabricMC/yarn

  • [x] ListMultiWidget should be MultiListWidget (though now that I think about it... I don't know what is Multi about the list at all? Either way, ListMultiWidget is not right)
  • [x] SkeletonBaseEntity should be AbstractSkeletonEntity
  • [x] EntityCat should be CatEntity
  • [ ] Entity datafixers...there's a few https://i.imgur.com/qsdgdZm.png

Most helpful comment

A few more:

  • [x] PlacementContextItem -> ItemPlacementContext
  • [x] net.minecraft.server.command.OutputCommand -> CommandOutput
  • [x] net.minecraft.server.command.SourceCommand -> CommandSource
  • [x] EntityProviderBlock -> BlockEntityProvider. Maybe BlockEntityProviderBlock, but probably not?

馃挴

All 8 comments

  • [x] BlockState was incorrectly changed to StateBlock

As far as data fixers are concerned, I think they are fine.

  1. They are following already specified names
  2. In the absence of entity, etc packages, the prefix is justified

hmm maybe. Not sure I agree though. I'd suggest make an entity package then.

I don't agree that the prefix is justified and am siding with @ProfessorProspector on this.

PlayerServerEntity -> ServerPlayerEntity

Actually, I agree the prefix is justified. Looking into it myself now.

Possibly also

  • [x] FactoryBlockEntity->BlockEntityFactory`?

A few more:

  • [x] PlacementContextItem -> ItemPlacementContext
  • [x] net.minecraft.server.command.OutputCommand -> CommandOutput
  • [x] net.minecraft.server.command.SourceCommand -> CommandSource
  • [x] EntityProviderBlock -> BlockEntityProvider. Maybe BlockEntityProviderBlock, but probably not?

馃挴

Was this page helpful?
0 / 5 - 0 ratings

Related issues

copygirl picture copygirl  路  6Comments

Runemoro picture Runemoro  路  4Comments

Sollace picture Sollace  路  5Comments

asiekierka picture asiekierka  路  4Comments

haykam821 picture haykam821  路  4Comments