Yarn: Inconsistent config strings

[olingern]

Continuation from #4457

Do you want to request a feature or report a bug?
Potential bug.

What is the current behavior?
Yarn config has different formatting for object keys that are computed / set vs defaults.

I'm not sure I understand if this is by design or not. If so, what is the use case?

Initial registry configuration

What is the expected behavior?
Keys should all be wrapped in single quotes or DEFAULTS should follow same formatting as registry, lastUpdateCheck, and user configured values do

Please mention your node.js, yarn and operating system version.
Yarn: 1.0.2
Node: 8.1.4

Happy to submit a PR if the current functionality isn't as expected.

[BYK]

This is by design but thinking again, maybe we should simply output JSON. @bestander @arcanis @Daniel15 thoughts?

[bestander]

[no opinion]

[olingern]

@BYK I can work on a JSON output if that's 👍

[Daniel15]

Why are some of them hyphenated (eg. version-tag-prefix) while others are camelcase (eg. lastUpdateCheck)? Can we make them consistent?

What appears to be happening here is that the keys with hyphens are quoted (as hyphen is not a legal character for a JS identifier) while the others are not.

[olingern]

@Daniel15 Oh, nice eye. For some reason I think I glossed over that.

Since words like emoji can't be hyphenated ( to my knowledge 🤔 ), seems like lower camel cased, non-hyphenated keys would be desirable?

[BYK]

@olingern I think a simple JSON.stringify() dump as we do for yarn run env would suffice. Fancy a PR?

[olingern]

@BYK Sure, I'll work on that and some test outputs

[sreeramjayan]

@olingern @BYK
I made a PR hoping to fix this. Please let me know if further changes are required.

[olingern]

@sreeramjayan Awesome. I'm traveling around Japan right now, and didn't get to this before leaving. Thanks for picking it up!

Looks like @BYK has a couple of things that need addressing in the PR. Cheers