Yarn: "Unmet peer dependency" with peer dependency already installed as transitive dep

[guigrpa]

Bug

What is the current behavior?

1. Install dependency A (with transitive dependency AB)
2. Later (contrary to #2132), install dependency C (which has AB as peer dep) -- an unmet peer dependency warning appears, even though AB was installed in the first step.

Repro

Step 1 output (notice that storyboard-core is installed as a normal dependency of storyboard):

$ yarn init -y
$ yarn add [email protected]
yarn add v0.19.1
info No lockfile found.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Saved lockfile.
success Saved 13 new dependencies.
...
├─ [email protected]
├─ [email protected]
...
Done in 4.25s.

Step 2 output (with storyboard-core in its peerDependencies; notice the warning):

$ yarn add [email protected]
yarn add v0.19.1
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning "[email protected]" has unmet peer dependency "storyboard-core@^3.0.0-rc.0".
[4/4] Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency.
└─ [email protected]
Done in 1.36s.

Despite the warning, the installation is successful. Also note that no peer-dep warning appears with npm install.

What is the expected behavior? No warning, since the peer dependency is already installed (with exactly the required version).

Please mention your node.js, yarn and operating system version.

Node v7.3.0
yarn v0.19.1
Windows 7 (also observed in OS X Sierra)

[CrabDude]

Still seeing in [email protected]:

// empty directory
$ yarn add webpack@3

[BYK]

@guigrpa your issue seems to be fixed on latest master.
@CrabDude your issue seems to be fixed with #4478.

[javonclarke]

@BYK I updated yarn based and the still persists for me when installing create-react-app globally.

~|⇒ yarn global add  create-react-app
yarn global v1.0.2
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning "[email protected]" has incorrect peer dependency "react@^0.15.0".
warning "[email protected]" has incorrect peer dependency "graphql@^0.6.0 || ^0.7.0 || ^0.8.0-b || ^0.9.0 || ^0.10.0".
warning "[email protected]" has incorrect peer dependency "prop-types@>=15.5.0".
warning "[email protected]" has incorrect peer dependency "react@^15.6.0".
warning "[email protected]" has incorrect peer dependency "react-dom@^15.6.0".
warning "[email protected]" has incorrect peer dependency "react@^15.6.1".
warning "[email protected]" has incorrect peer dependency "react@^0.14.0 || ^15.0.0".
warning "[email protected]" has incorrect peer dependency "react-dom@^0.14.0 || ^15.0.0".
warning "[email protected]" has incorrect peer dependency "react@^0.14.0 || ^15.0.0-0 || ^16.0.0-0".
warning "[email protected]" has incorrect peer dependency "redux@^2.0.0 || ^3.0.0".
warning "[email protected]" has incorrect peer dependency "react@^15.0.0".
warning "[email protected]" has incorrect peer dependency "react-dom@^15.0.0".
warning "[email protected]" has incorrect peer dependency "react@^0.14.0 || ^15.0.0".
warning "[email protected]" has incorrect peer dependency "react-addons-shallow-compare@^0.14.0 || ^15.0.0".
warning "[email protected]" has incorrect peer dependency "react-dom@^0.14.0 || ^15.0.0".
warning "[email protected]" has unmet peer dependency "svgo@>=0.4.0".
warning "[email protected]" has unmet peer dependency "webpack@1 || ^2 || ^2.1.0-beta || ^2.2.0-rc || ^3".
warning "[email protected]" has unmet peer dependency "webpack@>=1.3.0 <3".
warning "[email protected]" has incorrect peer dependency "codemirror@^5.26.0".
warning "[email protected]" has incorrect peer dependency "graphql@^0.6.0 || ^0.7.0 || ^0.8.0-b || ^0.8.0 || ^0.9.0 || ^0.10.0".
warning "[email protected]" has incorrect peer dependency "graphql@^0.7.0 || ^0.8.0 || ^0.9.0 || ^0.10.1".
warning "[email protected]" has incorrect peer dependency "graphql@^0.9.0 || ^0.10.0".
warning "[email protected]" has unmet peer dependency "webpack@^1.0.0 || ^2.0.0 || ^3.0.0".
[4/4] 📃  Building fresh packages...
success Installed "[email protected]" with binaries:
      - create-react-app
✨  Done in 5.32s.

Any help would be appreciated.

[BYK]

@javonclarke this issue is not fixed in 1.0.2, only on nightlies right now: https://yarnpkg.com/en/docs/nightly

[javonclarke]

@BYK Ah thank you.

[guigrpa]

@BYK Thanks for the effort!

[Hypnosphi]

I can reproduce the issue using OP's instructions in 1.3.2:

...
warning " > [email protected]" has unmet peer dependency "storyboard-core@^3.0.0-rc.0".
...

$ yarn list storyboard-core
warning Filtering by arguments is deprecated. Please use the pattern option instead.
└─ [email protected]

I checked on http://jubianchi.github.io/semver-check/, and it says that "3.1.3 satisfies constraint ^3.0.0-rc.0"

[greggb]

Is there anything I can do to help with a repro case? The Storybook issue is pretty much exactly what I'm seeing in my project as well on the latest release.

[BYK]

@Hypnosphi @greggb I think this is a separate issue. Sounds a bit like #4850 so feel free to comment there and follow it.

[Hypnosphi]

@BYK Do yo mean the one in storybook? Yeah, probably. But note that this one is also reproduceable right now

[BYK]

@Hypnosphi commenting under a closed issue won't get us any visibility, that's why I'm promoting an already open issue which seems like what you are reporting here :)

[Hypnosphi]

commenting under a closed issue won't get us any visibility

Should I open a new one instead, with exactly the same title and body? I just followed instructions from https://github.com/yarnpkg/yarn/issues/2688#issue-207140699 and got the same warning as OP using 1.3.2

[BYK]

@Hypnosphi yes, with a repro repo so we can reproduce locally without any other context of information and then fix it.

[greggb]

Thanks BYK