Yarn: Entity vehicle variable.

[darkevilmac]

The current name for what a user is currently riding in the Entity class is vehicle, I don't think this really makes much sense, I've never really heard anyone refer to things like horses or pigs as vehicles. I can make a PR for ridingEntity, mountedEntity, or something along those lines if anyone agrees.

[copygirl]

As mentioned in the PR, I'd prefer a different name for entities "riding" other entities. There's been vehicle, ride, mount, but what about attach? (By the way, that's by preference from least to most favorite.)

Anyone else have a suggestion?

[darkevilmac]

Attach doesn't really make sense for most scenarios. Again consider the
context, you don't attach yourself to a boat, a pig, or a minecart. You
don't mount the boat or minecart but you do mount a pig. You can also start
riding a pig though, and that matches most major use cases.

On Sep 28, 2016 8:57 AM, "copygirl" [email protected] wrote:

As mentioned in the PR
https://github.com/FabricMC/pomf/pull/96#discussion_r80952013, I'd
prefer a different name for entities "riding" other entities. There's been
vehicle, ride, mount, but what about attach? (By the way, that's by
preference from least to most favorite.)

Anyone else have a suggestion?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FabricMC/pomf/issues/94#issuecomment-250211596, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABusJIkc9bJ-YPoBXoq5IkYlP93enjq5ks5quo5vgaJpZM4KHH6k
.

[copygirl]

You do attach yourself to the boat, because now you're moving as the boat is moving. It makes the most sense, at least programmatically, in my opinion.

[darkevilmac]

Attach doesn't seem very intuitive to me, as a side note Minecraft throws
exceptions for add passenger telling the user to call start riding.
Changing them to other things has the potential to cause confusion.

On Sep 28, 2016 10:36 AM, "copygirl" [email protected] wrote:

You do attach yourself to the boat, because now you're moving as the boat
is moving. It makes the most sense, at least programmatically, in my
opinion.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FabricMC/pomf/issues/94#issuecomment-250240136, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABusJM5hdR_FeXogFeqhxcTrH4G0Nur0ks5quqWwgaJpZM4KHH6k
.

[copygirl]

Doesn't matter what Mojang calls it if we can name things better.

Attachments exist in other games as well, usually in the form of attaching things to body parts, connecting properties such as position and rotation. Attaching a player to a boat, minecart, horse or chair for example seems perfectly reasonable to me.

Riding may also be confusing due to the "is it riding or being ridden"? startRiding could very well mean "make the specified entity start riding this entity", where for example attachTo is very clear: player.attachTo(boat).

[darkevilmac]

What is confusing about player.startRiding or player.stopRiding. That seems
pretty clear to me.

In regards to Mojang naming its relevant in this case because the method
explicitly tells you to call another if you did something wrong. Giving it
another name entirely is going to cause confusion.

On Sep 28, 2016 10:56 AM, "copygirl" [email protected] wrote:

Doesn't matter what Mojang calls it if we can name things better.

Attachments exist in other games as well, usually in the form of attaching
things to body parts, connecting properties such as position and rotation.
Attaching a player to a boat, minecart, horse or chair for example seems
perfectly reasonable to me.

Riding may also be confusing due to the "is it riding or being ridden"?
startRiding could very well mean "make the specified entity start riding
this entity", where for example attachTo is very clear:
player.AttachTo(boat).

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FabricMC/pomf/issues/94#issuecomment-250245980, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABusJJNRNaOCb8as_eTR9zDK-9qsgfw9ks5quqpegaJpZM4KHH6k
.

[copygirl]

Does this mean we should take into account other error messages and crash reports too?

[darkevilmac]

If it was up to me I'd say yes but that's not the case. Unless we can start
remapping the messages in exceptions it makes sense to me at least to have
exceptions be accurate to the method name.

On Sep 28, 2016 11:45 AM, "copygirl" [email protected] wrote:

Does this mean we should take into account other error messages and crash
reports too?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FabricMC/pomf/issues/94#issuecomment-250261615, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABusJKlQGjC036nL2h58Z_bXcnSfZwDkks5qurXNgaJpZM4KHH6k
.

[copygirl]

Okay, I'll drop my resistance to your PR then, though I'd be interested to hear everyone else's opinions, still.

[mezz]

I like mounting things most, and riding next. You never attach to the side or bottom, in Minecraft you're always hopping on top of something.

Edit: actually riding makes more sense because while you can ride a pig and ride in a minecart, you don't really mount a minecart.

[copygirl]

@mezz Would you ride a seat or other stationary entity though, for example?

I'll speak out in favor of mount. It's a generic "get onto something" to me, common in games, clear in regards to getMountedEntity vs getMountingEntity, we can have mount and unmount (instead of start/stopSomething.

[modmuss50]

I agree with mezz, as riding fits in with all cases.

[mezz]

I think the only cases you would awkwardly ride a stationary thing is in modded, like bibliocraft chairs. All the other things I can think of move.

I do like mount and unmount because they are a simple pair of operations that are common in computers. "unmount" is a weird computers-word, the normal English word is "dismount". We don't have something similar for ride like unride. We could still use startRiding and stopRiding, but I like the mounted versions better than getRidingEntity and getRiddenEntity. Hm.

[Prospector]

I like mount and dismount personally