Some of the names of classes might be modified. Ex. TileEntity -> BlockEntity, Minecraft -> MinecraftClient. Those classes have a more accurate name but they were not renamed because in other decompiling projects people were too lazy to change those common-used names.
liach
All 11 comments
Not quite sure what this issue is for specifically. I think we specifically try to avoid using other mapping's names, but in some cases the name stuck, causing the community to adopt it. I'd love to have a place to point out possible name changes of important classes and discuss them.
Regarding the naming of blocks / tile entities, there's also the alternative of renaming Block -> Tile, which seems to be Mojang's convention of calling blocks. (Though I myself would prefer moving to BlockEntity.)
And regarding MinecraftClient, I'm not sure if that's appropriate. Perhaps something along the lines of Game or App might me more fitting?
copygirl
on 9 Sep 2016
According to MinecraftWiki at least, the TileEntities are now internally indeed called BlockEntities, which might make the TileEntity->BlockEntity rename a good idea. http://minecraft.gamepedia.com/Block_entity
MinecraftServer is already a thing, but MinecraftClient also handles the integrated server... MinecraftGame?
asiekierka
on 9 Sep 2016
I think MinecraftClient makes more sense as it matches with the naming of
the MinecraftServer class.
On Sep 9, 2016 4:13 AM, "Adrian Siekierka" [email protected] wrote:
According to MinecraftWiki at least, the TileEntities are now internally
indeed called BlockEntities, which might make the TileEntity->BlockEntity
rename a good idea. http://minecraft.gamepedia.com/Block_entityMinecraftServer is already a thing, but MinecraftClient also handles the
integrated server... MinecraftGame?—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/FabricMC/pomf/issues/66#issuecomment-245885589, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABusJFhxkmGe4ZveVsD7m6MDHm_7CIdGks5qoT9ZgaJpZM4J4qSD
.
darkevilmac
on 9 Sep 2016
@darkevilmac Yeah you are the one who suggested that name change in mcp but was rejected by the bad tempered guy.
liach
on 9 Sep 2016
Yup, almost forgot I had suggested that until now.
On Sep 9, 2016 12:26 PM, "liach" [email protected] wrote:
@darkevilmac https://github.com/darkevilmac Yeah you are the one who
suggested that name change in mcp but was rejected by the bad tempered guy.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FabricMC/pomf/issues/66#issuecomment-246014311, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABusJE7Vzf7w0y2pdxoOLAReHbM_kJ92ks5qobLigaJpZM4J4qSD
.
darkevilmac
on 9 Sep 2016
@darkevilmac That would only make sense if Client and Server were opposites, but Client has its own Server...
asiekierka
on 9 Sep 2016
@asiekierka I don't think it's unheard of to have a game client with an integrated server. If it was running the server and the client all by itself I'd understand but as it is now there's still some separation there.
As a side note, from the issue I had initially made on MCP the official Mojang name is known to be Minecraft. Considering they're such important classes it might make sense to leave them as is.
darkevilmac
on 9 Sep 2016
Ok. We still may actually use BlockEntity though.
liach
on 9 Sep 2016
The following renaming has been done:
TileEntity => BlockEntity (#76)
Minecraft => MinecraftGame (#82)
copygirl
on 17 Sep 2016
Ok well this has been done for 2 years. Close?
Prospector
on 27 Nov 2018
Sorry, I should have closed this.
liach
on 27 Nov 2018
Related issues
haykam821
·
4Comments
Sollace
·
5Comments
enbrain
·
4Comments
altrisi
·
4Comments
Runemoro
·
4Comments
Most helpful comment
I think MinecraftClient makes more sense as it matches with the naming of
the MinecraftServer class.
On Sep 9, 2016 4:13 AM, "Adrian Siekierka" [email protected] wrote: