Yalpstore: App crashes on login

[m4rkusxxl]

Running 0.35 on LineageOS 14.1.

Expected behaviour

Search for name or updates. Login and search.

Actual behaviour

Searching for a name or updates will pop up the "log in" dialog. Then the app crashs.

Steps to reproduce

Install yalp with f-droid. Search for anything in yalp.

Info about your device

Newly installed LineageOS 14.1 on Redmi5.

[murkom]

Same phone, also with lineage.
Same behaviour.

[yeriomin]

@m4rkusxxl @murkom Its hard to say anything without a crash log. Please send the crash report when Yalp Store suggests. Mark it with your name and/or this issue number. Also, please use the latest version: 0.37.

[murkom]

Used version 0.37.
Opened yalp, pressed check updates. It tried to used default credentials and crashed. Happens everytime with any yalp version.
Searched log for yalp. Don't know if you need more from log.
https://pastebin.com/bLqzwHMV

[m4rkusxxl]

At the time of the report the 0.35 was the current. Of course I updated to 0.37 once it was served by fdroid, but the update didnt change anything for this issue.
I already sent some report from yalps integrated problem report entry.
What else is needed? (I dont know what "the crash report when Yalp Store suggests" should mean. I never get the option to send some report when crash happens.)

[m4rkusxxl]

logcat.log

[murkom]

v0.38 still doing the same.
Forgot to say that i don't have any type of gapps instaled.
Also tried older versions of yalp and they all have same behaviour.

[yeriomin]

@m4rkusxxl This is a duplicate of #175 ... which was not fixed. This crash happens in Yalp Store's dependency (protobuf). It happens during the login attempt. Redmi5 is not a rare device which means it does not depend on the device. Also, apparently, the crash does not happen on debug builds.

Could you try setting a different device definition in the settings before trying to log in?

@murkom Your crash also happens during login, but your log has too much info cut out. Could you post an full version? If it is the same (stack overflow in the protobuf library), try setting a different device too.

Searched log for yalp.

The lines I'm interested in do not have "yalp" in them.

[m4rkusxxl]

Set it to spoof a "xiaomi mi5" in yalp setting, still crashs:
logcat.log

[murkom]

Another log:
https://upload.disroot.org/r/2C9WFCgw#0W9CEKYAzUgj9IrDa05fCM0OhGWa6hrGpSdXfRz7XO4=

Spoof to another device does not work.
Forgot to say that yalp worked with official rom.

[yeriomin]

@m4rkusxxl I see.
@murkom This log tells me that it is indeed the same problem.

I built an apk which might work for you. Please test it. I could not reproduce this problem on any device I had, so this fix is guesswork and I will only add it to the repo if you test it and it works...

app-legacy-release.zip

[murkom]

It's working. All good. Thank you for your work!!

[m4rkusxxl]

Working here as well.

[yeriomin]

@m4rkusxxl @murkom Thanks for checking.