Xud: SWAP: Two parallel swaps cause channel to force close

[offerm]

Way to reproduce:

Have swap setup properly.
create 2 limit orders (Maker)
Issue a market order that clear both limit orders.

Log:

2018-08-31 21:23:03.751 [DBG] HSWC: ChannelLink(1411912:266:1) Queueing keystone of ADD open circuit: (Chan ID=0:0:0, HTLC ID=10005)->(Chan ID=1411912:266:1, HTLC ID=38)
2018-08-31 21:23:03.751 [DBG] PEER: Sending UpdateAddHTLC(chan_id=70dc7283d324a46a8065b33d4987450dc4963899b0f82320cda7acbfe83005ad, id=37, amt=351160000 mSAT, expiry=1411986, hash=e59250287bf057080526b01a7f3bfc51043c029fab7ff32a7fbdc724d3c193ab) to 127.0.0.1:20012
2018-08-31 21:23:03.751 [DBG] PEER: Sending UpdateAddHTLC(chan_id=70dc7283d324a46a8065b33d4987450dc4963899b0f82320cda7acbfe83005ad, id=38, amt=359939000 mSAT, expiry=1411986, hash=10c116a636f2b2382b3327c303862ac9cb5ffd380f6b698c96da3556b2e25dec) to 127.0.0.1:20012
2018-08-31 21:23:03.811 [DBG] HSWC: ChannelLink(1411912:266:1) removing Add packet (Chan ID=0:0:0, HTLC ID=10006) from mailbox
2018-08-31 21:23:03.811 [DBG] HSWC: ChannelLink(1411912:266:1) removing Add packet (Chan ID=0:0:0, HTLC ID=10005) from mailbox
2018-08-31 21:23:03.824 [DBG] PEER: Sending CommitSig(chan_id=70dc7283d324a46a8065b33d4987450dc4963899b0f82320cda7acbfe83005ad, num_htlcs=2) to 127.0.0.1:20012
2018-08-31 21:23:03.828 [DBG] PEER: Received RevokeAndAck(chan_id=70dc7283d324a46a8065b33d4987450dc4963899b0f82320cda7acbfe83005ad, rev=4a4d87bdfa5b06401ee012492e3d9867490edadcb3bf2ebcaa3908eb7ef4d5da, next_point=03c78678922a14d3c360b57339adcd029ffd434a2328e88466c2ced5e5daa95534) from 127.0.0.1:20012
2018-08-31 21:23:03.843 [DBG] PEER: Received CommitSig(chan_id=70dc7283d324a46a8065b33d4987450dc4963899b0f82320cda7acbfe83005ad, num_htlcs=2) from 127.0.0.1:20012
2018-08-31 21:23:03.845 [DBG] PEER: Sending RevokeAndAck(chan_id=70dc7283d324a46a8065b33d4987450dc4963899b0f82320cda7acbfe83005ad, rev=edbe1376fba21b568b77cd9fc57fcf9fe5d602ace967f309a2a890f4c0339400, next_point=02b4fb80ec34241bd9670563fe11ca041d00f78e24e4e7133e78ab2f3632f85dca) to 127.0.0.1:20012
2018-08-31 21:23:08.633 [INF] HSWC: Sent 0 satoshis and received 0 satoshis in the last 10 seconds (0.100000 tx/sec)
2018-08-31 21:23:23.862 [DBG] PEER: Received UpdateFailHTLC(chan_id=70dc7283d324a46a8065b33d4987450dc4963899b0f82320cda7acbfe83005ad, id=38, reason=bdc0fd35903fafa94c75d33a3aed16a36bc77fb7b7d5432a0366e5aa2829033aa359384ce30895abc9222b63af042490d2c8d4b1ce304ad2a18b77fb4635e66d256f503f77c1426c003737c1b478441e82695b8b2358c79c4928aa844fb7a7d43e2d2cb5a606c164095c1414f7d9fa00de9e924bca9fa67f2fd352d4d05f9ffef7348ab05942bf3ba02ade378eb71dbca1550765b2a4006d985b96033c5a829c1a35f2ca1ace7623763b365681c0200e6023bb14ee87903ded5732e70245da28ed1bec673eb2ae2486e585a585f4f6a54662598e4ee71427720e4c1da82af2b8b1d2a1f5a5b59c30b14e935fb2698e8ffce6b91dcd8c791101715d8d975a94c0ec40f3b55e58e2c5c20251e6094145ec173528e050b2e445ea4e8114ccec6c3a75087a01) from 127.0.0.1:20012
2018-08-31 21:23:23.866 [DBG] PEER: Received UpdateFailHTLC(chan_id=70dc7283d324a46a8065b33d4987450dc4963899b0f82320cda7acbfe83005ad, id=37, reason=2f18220040528f6e5893e5e0e128f18fe36b38e90507a4aeb8c37478796532a6b9635318df3a431485c49af698beb1339b4163aa28b68a93dc4fcc1fa11b534edeb465abfabce33273ef2b152a4579df0e4c92035ae53f68ad14e03b05b00b54e806b7800b53aea5c1e51361953f558cf6d52b38d043b5301d89ddf0e5334783c2328fb5af65b5268aa7d40470f655f6c5c6e56be5f57a656a9c7915c89a2657be58ae692a61090072b61ece2dd828cd65aa8c1f5b6d1d4decba4cd4db3553a6173f2a0b0ee5845e2b1ea70381379da2efdb255cd6899ee349e86b0898d4693e859a76ddfa6e193c24c49c15ddf2e423c7cbc145b4e1bc471b1ef49cda8b7ab51018e1b2797f3906bd4eb07045810202c87f6d1f2dd33cfa8bcfd4325ec92a1eef5dddf2) from 127.0.0.1:20012
2018-08-31 21:23:23.878 [DBG] PEER: Received CommitSig(chan_id=70dc7283d324a46a8065b33d4987450dc4963899b0f82320cda7acbfe83005ad, num_htlcs=1) from 127.0.0.1:20012
2018-08-31 21:23:23.880 [ERR] HSWC: ChannelLink(1411912:266:1) Failing link: ChannelPoint(ac0530e8bfaca7cd2023f8b0993896c40d4587493db365806aa424d38372dc70:1): unable to accept new commitment: number of htlc sig mismatch. Expected 0 sigs, got 1
2018-08-31 21:23:23.880 [ERR] HSWC: ChannelLink(1411912:266:1) link failed, exiting htlcManager
2018-08-31 21:23:23.880 [INF] HSWC: Removing channel link with ChannelID(70dc7283d324a46a8065b33d4987450dc4963899b0f82320cda7acbfe83005ad)
2018-08-31 21:23:23.880 [INF] HSWC: ChannelLink(ac0530e8bfaca7cd2023f8b0993896c40d4587493db365806aa424d38372dc70:1) is stopping
2018-08-31 21:23:23.880 [INF] HSWC: ChannelLink(ac0530e8bfaca7cd2023f8b0993896c40d4587493db365806aa424d38372dc70:1) has exited
2018-08-31 21:23:23.985 [WRN] PEER: Force closing link(1411912:266:1)

[offerm]

Done by an update to resolver PR (LND).

Managed to run 5 parallel swaps without an isseue

OK to close? @kilrau

[kilrau]

Yep