Xterm.js: Windows Powershell resize

[trungutt]

I made an Electron app using xterm.js to integrate a terminal.

When the default terminal is Powershell, it doesn't resize correctly when maximizing/unmaximazing the windows. The same thing happened on Hyper, or Electerm which use xterm internally.

When using other things than Powershell, like cmd.exe, that works fine.

Details

• Browser and browser version: Chrome
• OS version: all Windows versions
• xterm.js version: latest version

Steps to reproduce

1. Default shell to Powershell
2. Download and install Electerm on Windows (for example)
3. type ls
4. maximize the window (if it's not already maximized)
5. unmaximize the window
6. maximize the window
7. type ls and see that ls is not positioned correctly

Screen capture here:

[Tyriar]

OS version: all Windows versions

What version of windows are you on? Type ver into cmd.

[mat007]

@Tyriar I’m on @trungutt’s team, I have the same issue, here is my Windows version

Microsoft Windows [Version 10.0.19592.1001]

I guess we’re all running Insider Rings versions on the team.

[Tyriar]

@mat007 does it happen when you try on Windows Terminal?

[Tyriar]

Also how are you creating the pty backend?

[Tyriar]

https://github.com/electerm/electerm/blob/1f2d7b3ba83736e4a423567e454eb442d28db986/src/app/server/session.js#L135-L141

Try setting the useConpty: true.

[mat007]

does it happen when you try on Windows Terminal?

As a matter of fact, it does! So I guess that means it’s a Powershell terminal bug…

[Tyriar]

@mat007 if it repros in windows terminal is means it's a conpty bug. You should report to https://github.com/microsoft/terminal

[mat007]

Thanks @Tyriar 👍

[trungutt]

A bit late but thanks @Tyriar

[trungutt]

So I created another ticket on that https://github.com/microsoft/terminal/issues/5254