Xterm.js: Clickable multi-line links have regressed

Created on 22 May 2019  路  5Comments  路  Source: xtermjs/xterm.js

Upstream issue: https://github.com/microsoft/vscode/issues/61708
Old PR that solved the issue (things have changed a lot in the area though): https://github.com/xtermjs/xterm.js/pull/1769

We should verify the state of the bug before tackling this.

arelinks help wanted typbug

All 5 comments

I would like to look into this

@kamalesh0406 sounds good 馃憤

Screen Shot 2019-06-24 at 3 40 55 PM

I think the bug has been resolved.

@kamalesh0406 Multiline support in general works yeah, but there are issues with special conditions of chars:

  • combining chars/wide chars in the line prior the URL (or any content to be linkified) might offset the underline (both start and end)
  • combing chars/wide chars within the linkified content might offset end of underline
  • on resizing the URL might contain wrong (truncated or wrongly filled in spaces) content

You might want to look at some test cases in #1769 to get a hold of those exotic conditions.


Repro steps:

  1. Fill terminal
  2. clear
  3. Execute a program which prints a link longer than the current size of the terminal.
Was this page helpful?
0 / 5 - 0 ratings

Related issues

jerch picture jerch  路  3Comments

kolbe picture kolbe  路  3Comments

Tyriar picture Tyriar  路  4Comments

johnpoth picture johnpoth  路  3Comments

pfitzseb picture pfitzseb  路  3Comments