Xterm.js: Support strikethrough text style

[Tyriar]

I notice these aren't implemented:

• Dim \e[2m -> opacity: 50% (Done)
• Italics \e[3m -> font-style: italic (Done https://github.com/xtermjs/xterm.js/pull/1422)
• Strikethrough \e[9m -> text-decoration: line-through

[lucat1]

Is this implemented as of today?
The css is here, but for me it's not working inside of vim, macOS

[Tyriar]

It's not implemented, what CSS are you referring to?

[lucat1]

Sorry for the CSS part, I thought to have seen it there

Are you planning on implementing this soon or is this a low priority task?

[Tyriar]

Those are for the ones that are implemented.

This is low priority and is blocked by https://github.com/sourcelair/xterm.js/pull/756 which is reimplementing how the character attributes are stored.

[mofux]

Here is a nice script to test the different styles:

https://gist.githubusercontent.com/mxmerz/92e97cd27857a9ba787b/raw/c16c216d11c3fa6e7f0254e2d5f485164cddfb96/ANSI-Test.sh

[lucat1]

Cool! 😍

[flybayer]

Oh man, I want this so bad (italic).
It looks like this is no longer blocked by anything, correct?

[Tyriar]

Italics fixed in https://github.com/xtermjs/xterm.js/pull/1422

[felixfbecker]

Strike through would be really great. Git supports it as a diff style: git config --global diff.color.old "red strike"

PowerGit uses it for gone branches:

[Tyriar]

If anyone wants to help out with this you will want to copy how underline works in the DOM (DomRendererRowFactory.ts) and canvas renderers (TextRenderLayer.ts), for the latter a new method like fillBottomLineAtCells will need to be done which draws a line through the middle.