Xterm.js: Right click generating an error

[oddjobz]

New xterm is working fine for me, scrollbar works, mousescroll works, click drag works, but right click generates an error ...

xterm.js:484 Uncaught DOMException: Failed to execute 'getRangeAt' on 'Selection': 0 is not a valid index.(…)
rightClickHandler @ xterm.js:484
(anonymous function) @ xterm.js:653

Details

• Browser and browser version: Google Chrome (latest)
• OS version: Ubuntu 16.04
• xterm.js version: Version in /dist as of today

Steps to reproduce

1. Right click on an active xterm.js scrollbar

[parisk]

Thanks for reporting @oddjobz. Taking a look. Did you have any text selected when right-clicked?

[oddjobz]

Nope, the xterm is sat in a gridstack which grabs the mouse, so selecting text isn't possible ..

[parisk]

@oddjobz I just pushed 00dcb4f6e3f23139cc638c3061f97a2e999f27ad at #332, which hopefully fixes your issue.

Can you test this out by following these steps?

1. Checking out xterm.js to 00dcb4f6e3f23139cc638c3061f97a2e999f27ad
2. Building it (npm install && BUILD_DIR=dist npm run build)
3. Reloading your page

[oddjobz]

Yes, that fixed it!
Many thanks!!

[parisk]

Great. After it gets a successful code review we will merge it into master and it will make it to 2.1.