Xonsh: Do we really support python3.5?

Created on 1 Aug 2020  Â·  5Comments  Â·  Source: xonsh/xonsh

According to the docs xonsh supports python3.5, but it doesn't seem to actually support it:

  • There are f-strings in a lot of places
  • The CI only runs with python3.6 and above
  • Black only runs with python3.6+

Shouldn't the docs and setup.py change to python3.6+?

Most helpful comment

As a point, IPython got a new release yesterday marked at 3.7+.

On Sat, Aug 1, 2020, 06:45 Morten Enemark Lund notifications@github.com
wrote:

I think everyone agrees we should drop 3.5.

So unless anyone @xonsh/xore https://github.com/orgs/xonsh/teams/xore
objects a PR removing 3.5 would be very welcome :)

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/xonsh/xonsh/issues/3651#issuecomment-667534690, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACR5TZOA2KZZUYFQGX43HTR6QMABANCNFSM4PRSADVQ
.

All 5 comments

I think everyone agrees we should drop 3.5.

So unless anyone @xonsh/xore objects a PR removing 3.5 would be very welcome :)

As a point, IPython got a new release yesterday marked at 3.7+.

On Sat, Aug 1, 2020, 06:45 Morten Enemark Lund notifications@github.com
wrote:

I think everyone agrees we should drop 3.5.

So unless anyone @xonsh/xore https://github.com/orgs/xonsh/teams/xore
objects a PR removing 3.5 would be very welcome :)

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/xonsh/xonsh/issues/3651#issuecomment-667534690, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACR5TZOA2KZZUYFQGX43HTR6QMABANCNFSM4PRSADVQ
.

please someone kill 3.5

or I can get to it later this week.

3654 is step toward it.

Awesome! Thanks!

Was this page helpful?
0 / 5 - 0 ratings