Xo: Parsing error: Cannot read property ecmaFeatures of undefined when eslint also installed

[graingert]

When eslint and xo are both installed, the run fails with: Parsing error: Cannot read property ecmaFeatures of undefined

https://travis-ci.org/graingert/eslint-ecma-featured-of-undefined/jobs/401852495
https://github.com/graingert/eslint-ecma-featured-of-undefined/commit/a6d1d12b8d3f0ab437f9c1d086825370fb860e03

[graingert]

I can't upgrade xo in my project (an eslint plugin) because it fails to run: https://github.com/jfmengels/eslint-plugin-lodash-fp/pull/71

[pvdlg]

I imagine this is because [email protected] is meant to works with eslint@4 and not eslint@5.
The next release of XO will use eslint@5.

[graingert]

But it should use it's own nested copy of eslint

[pvdlg]

After further investigation the problems disappear when removing the node plugin.
Not sure why yet.

[mdupont]

FWIW, the problem also disappears after upgrading eslint-plugin-node from ^6.0.0 to ^7.0.0 for xo. I haven't tested it extensively though, and it's a major version bump.

[pvdlg]

Thanks for the heads up @mdupont. Nice profile picture btw.

[pvdlg]

Fixed in #344

[tmilar]

Hi @pvdlg , I just ran into this issue too when trying to upgrade eslint to 5.2.0.
Upgrading XO to latest version 0.21.1 didn't help, but manually installing eslint-plugin-node ^7.0 solved the issue: npm install --save-dev --save-exact [email protected]

[graingert]

@pvdlg can you ping me when this is released, so I can update eslint-plugin-lodash-fp?