Xo: Expects 5 indentations instead of 4 since recently

Created on 18 Mar 2017  路  4Comments  路  Source: xojs/xo

I came across this in np as of today, not sure why it never failed earlier.

Apparently, XO expects 4 indentations instead of 5 in this code block. Right here and here. I'm not sure if XO can actually do something about that as it looks like it's an ESLint rule.

Sorry for the quick explanation but don't have much time now to look into it.

bug
Source
picture SamVerschueren

Most helpful comment

Seems like it will be fixed in ESLint 4 in a couple of months, so we can just leave this here until then.

picture sindresorhus on 18 Mar 2017
👍3

All 4 comments

Seems like it's because of https://github.com/eslint/eslint/issues/7320.

I've disabled it for now: https://github.com/sindresorhus/eslint-config-xo/commit/023a7ab5323e5175d4fcd8ca50ed07779473ca8a

sindresorhus picture sindresorhus on 18 Mar 2017

Thanks!

SamVerschueren picture SamVerschueren on 18 Mar 2017

Seems like it will be fixed in ESLint 4 in a couple of months, so we can just leave this here until then.

sindresorhus picture sindresorhus on 18 Mar 2017
👍3

New version is out: https://github.com/xojs/xo/releases/tag/v0.20.0

sindresorhus picture sindresorhus on 14 Feb 2018
Was this page helpful?
0 / 5 - 0 ratings

Related issues

sindresorhus picture sindresorhus  路  8Comments
sindresorhus picture sindresorhus  路  6Comments
dawsbot picture dawsbot  路  5Comments
haskellcamargo picture haskellcamargo  路  3Comments
DavidAnson picture DavidAnson  路  8Comments