Xlpagertabstrip: iPhoneX safe area problem.

[ShockUtility]

There is a problem with the 'safe area' in landscape mode on iPhoneX.

Xcode 9.2(9C40b)
iOS 11.2
XLPagerTabStrip : 2017.12.06 download

[brianb7590]

Seeing the same problem on a project using the library. Safe Area seems to be ignored when in Landscape.

[leetal]

Yes, this is a real issue. It seems like the cached size of the view is retained and not recalculated upon rotation on a device that respects safe are guides.

[artur7]

You can fix it by calling :

override func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) {
        coordinator.animate(alongsideTransition: { (_) in

        }, completion: { _ in
            self.reloadPagerTabStripView()
        })

        super.viewWillTransition(to: size, with: coordinator)
    }

in parent container View Controller

[DanielBalsalobre]

Same problem here, version 8.0.1

[DanielBalsalobre]

Solved!!!

ON PagerTabStripViewController 242 to 254 replace the code with this IF block

if let _ = childController.parent {
if #available(iOS 11.0, *) {
childController.view.frame = CGRect(x: offsetForChild(at: index) + view.safeAreaInsets.left, y: 0, width: view.bounds.width - (view.safeAreaInsets.left + view.safeAreaInsets.right), height: containerView.bounds.height)
} else {
childController.view.frame = CGRect(x: offsetForChild(at: index), y: 0, width: view.bounds.width, height: containerView.bounds.height)
}
childController.view.autoresizingMask = [.flexibleHeight, .flexibleWidth]
}
else {
childController.beginAppearanceTransition(true, animated: false)
addChildViewController(childController)
if #available(iOS 11.0, *) {
childController.view.frame = CGRect(x: offsetForChild(at: index) + view.safeAreaInsets.left, y: 0, width: view.bounds.width - (view.safeAreaInsets.left + view.safeAreaInsets.right), height: containerView.bounds.height)
} else {
childController.view.frame = CGRect(x: offsetForChild(at: index), y: 0, width: view.bounds.width, height: containerView.bounds.height)
}
childController.view.autoresizingMask = [.flexibleHeight, .flexibleWidth]
containerView.addSubview(childController.view)
childController.didMove(toParentViewController: self)
childController.endAppearanceTransition()
}

[ikesyo]

This is just an example problem. Safe area should be handled in each child (content) view controller (otherwise child view controller can't fill the background of entire screen). So

childController.view.frame = CGRect(x: offsetForChild(at: index) + view.safeAreaInsets.left, y: 0, width: view.bounds.width - (view.safeAreaInsets.left + view.safeAreaInsets.right), height: containerView.bounds.height)

this is not correct.

We can fix the example by updating PostCell (to use UITableViewCell.insetsContentViewsToSafeArea). I'll address it.

[ikesyo]

Submitted #612.

[rene-dohan]

Why this still doesn't work for me ? The incorrect solution from DanielBalsalobre looks like works fine so I will use that probably. Maybe because I don't use storyboards , just using lib programmatically, maybe that is not addressed in this issue ??

[rene-dohan]

Or somethinng like this...

override open func updateContent() {
        super.updateContent()
        for (index, childController) in controllers.enumerated() {
            childController.view.frame = CGRect(x: offsetForChild(at: index) + view.safeAreaInsets.left,
                    y: 0, width: view.bounds.width - (view.safeAreaInsets.left + view.safeAreaInsets.right),
                    height: containerView.bounds.height)
        }
    }

[antileks]

My solution (based on rene-dohan's answer):

override open func updateContent() {
  super.updateContent()
  if viewControllers.count > currentIndex {
    viewControllers[currentIndex].view.setNeedsUpdateConstraints()
  }
}