Xenia: OpenGL was fully broken

[Parovozik]

I understand that now the main Vulkan api.
I just want to report that I discovered a problem that appeared a month ago and OpenGL became completely broken (the emulator itself starts up, but the attempt to launch any game will immediately cause a critical error)
The last working build at (https://github.com/benvanik/xenia/commit/e54c24e1505e597ed29a133f162686e13d7294c5)
The next one already has this problem (https://github.com/benvanik/xenia/commit/b17d6f5088976b5aed12e45d44bf5c73d91bc41d).
Was changed file to path 'src-xenia-base-memory.cc'. If use 'base-memory.cc' from (https://github.com/benvanik/xenia/commit/e54c24e1505e597ed29a133f162686e13d7294c5) to any new build, example last (https://github.com/benvanik/xenia/commit/c5dbcc7e80bfa6b859a13799baf540495fec63d4) then OpenGL again works.
So, if for some reason you are interested to see how OpenGL works (or compare it with emulator work on Vulkan api), you can use this method, replacing 1 file :yum:
Crash logs from last master (https://github.com/benvanik/xenia/commit/c5dbcc7e80bfa6b859a13799baf540495fec63d4):
xenia OGL cr1.log
xenia OGL cr2.log
xenia OGL cr3.log

[raynebc]

I built 6b8a34c9 a week and a half ago from the then-latest Git source and was able to launch a game with OpenGL with functionality comparable to 4 months prior.

[Parovozik]

Just look

Feb.14 OGL:

March 4 OGL:

And more interesting OGL vs Vulkan last build (this last level of game and here OGL still wins):

[raynebc]

I'm just pointing out that your claim about trying to emulate ANY game with OpenGL results in "critical error" is not the case. The emulation of some/many games is probably unchanged over the past several months of commits.

[Parovozik]

No. On all master builds from Feb15.2018 and next, OGL not works for all games.

[raynebc]

https://github.com/xenia-project/game-compatibility/issues/720#issuecomment-370292522

This is a game that worked with OpenGL on a build newer than February 15. So you are incorrect. It's not worth arguing about, just correct your information and move on.

[Parovozik]

If OGL works for you this does not mean that no one has problems with it

[raynebc]

The point you are missing is that OpenGL is not completely broken and unusable for all games as you claimed.

[Irixion]

Opening titles that previously worked with GL no longer work now. While GL is "deprecated" it is actually more accurate than Vulkan is at this point in time.

[LuismaSP89]

I can confirm this issue, the latest build that worked with Opengl was "Feb 14 2018" after that, all games I have, crash when I try to open under Opengl. Vulkan has no problem.

[raynebc]

I was able to emulate Bandfuse in OpenGL with yesterday's Xenia code base. It rendered to only one quarter of the emulator window, but it did not crash. At most, this crash issue only affects some games/hardware.

[DrChat]

Closed; OpenGL is deprecated.

[raynebc]

Hopefully Vulkan rendering gets up to par.