Xenia: VRAM memory leak trouble (Vulkan)

[Parovozik]

Tested on many builds include 1.0.923 (https://github.com/benvanik/xenia/commit/89780b5c73d819b41224e6e81a4fa2c0f922d5b6)
Since March, there has been a problem with memory leakage in some games. Here are some examples:

Logs:

Harry_Potter_DH_Part1_VK.txt
Midnight_Club_LA_VK.txt
Samurai_Shodown_Sen_VK.txt
Red_Dead_Redemption_VK.txt

Screenshots:

[AllanCat]

Just did a quick search, #c4b728b's overlap detecting for loop causes this issue. So it might be related to access_watch_handle in texture_cache where it is destroyed when touched. Again right now command out this for loop fixes issue temporary.

[Parovozik]

@AllanCat Thanks. I will try it :)
*This fixed memory leak for RDR, MC LA and Harry Potter, but Samurai Shodown Sem still have leakage, maybe just here specific trouble, not global.
Thanks :)

[Parovozik]

On the last master-build of Xenia i see a trouble with memory leak (vram) for many new games. Example Lego Batman, Lego Indiana Jones and others
Upd. Build (https://github.com/benvanik/xenia/commit/573b3c388acbe57047b47a13e20c1cea9498ecbc) (https://ci.appveyor.com/project/benvanik/xenia/build/1.0.957-master) have some specific works. Source was deleted, but 'exe' still available. 957 can start some game on Vulkan (example NFS MW, NFS Carbon, Transformers the game, GTA 4, Limbo, TMNT, Fifa Street 3...) but for many games trouble with memory leak (vram).
Yearlier or more newer builds (as 958 for now) cant start them (only OGL mode), but memory leak exact only for RDR, MC LA.. as my 1st message.
Where i can take source code on 1.0.957? (and list changes files)

[Parovozik]

For last build of Xenia i see Memory Leak for many new games, example Catherine, Ultimate Marvel vs Capcom 3...

[Parovozik]

Memory Leak fix for RDR, MC LA, Catherine and other many games on current Xenia-master build
Open source: src/xenia/cpu/mmio_handler.cc
and disable small block lines from 111 to 144 (just mark as commented inside /* */)
Done :yum:

Compiled last master + fix:

https://drive.google.com/open?id=1f938xbrsJ4j7fMSZCShOlktyYc67oIs0

[WRTuL]

Interestingly with your build @Parovozik Halo Reach doesn't crash anymore, some menus however are pure black and some aren't https://i.imgur.com/U1dTV0H.png Pretty sure it's Firefight lobby.

Main menu: https://i.imgur.com/NGGxh0I.png random yellow letters popup when exiting other menus.

[Parovozik]

@WRTuL Yep, Halo 3 ODST not crashes now too :yum:

[WRTuL]

I noticed when you press F5 Xenia throws out an error about GPU device being lost (internal error). I have yet to rip my copies of 3 and ODST :P

[kkthxbye-code]

I can confirm that red dead redemption crashes with vulkan on a GTX 1080 in about 7 seconds, as soon as it starts rendering 3D, the VRAM usage rises by 1 GB per second until it crashes at the 8 GB the card has.

[jackchentwkh]

for any games in menu status, keep it there and watching the ram usage. You can see that the ram usage keeps pumping up all the time. it's very obvious there is memory leak.

[jackchentwkh]

@Parovozik could you please put the code you modified in plain text here?
because with your expression, by marking out line 111 to 133, doesn't make sense to me at all.
or maybe you're talking about marking out line 121 to 133? the if else statement?

[Parovozik]

@jackchentwkh mark as 'red text'

[jackchentwkh]

in the source file, it should be line 113 to 144. now I see. but the code itself looks fine to me. How did you figure out this section of code has bug?

[Parovozik]

i tried many games and this works without any side effects, only memory leak repair and for some games even less graphics glitches (silent hill 3 hd for example) and much better performance (silent hill 3 hd, sonic 2006, bayonetta...)

[jackchentwkh]

I believe you. But I am curious how you figured out this is the source of the leak?