I think with the multiple recent breakages we've just had due to dependency upgrades, we should push out a patch release with some haste.
Please comment/add/object
allow_lazy #3435 Would be nice to get this out - just hit #3426. (I now updated to master but this is besides the point).
@mathause I'm personally really uncomfortable pushing out a release when there are multiple known breakages against dependencies - see Must have list. Help is welcome!
@barronh any update re pseudonetcdf 3.1?
I believe there are two issues here.
First, the 3.1 release was not 2.7 compliant. It mixed named keyword arguments with **kwds. That could be fixed easily.
Second, the camx reader changed subclasses, which affects the xarray test for CF variables. I could update the test that would fix xarray test-case.
@barronh, we don't care about Python 2.7 compliance. We support >=3.6.
Got it. This is a test update to a test that is backward and forward compatible. I'll get something checked in.
xref for numpy 1.18 numpy/numpy#14831
@mathause Thanks for filing these upstream issues!
Once #3491 is merged, we should be ready to release since numpy will fix itself (https://github.com/numpy/numpy/pull/14841)
Don't we have to figure out whether to use np.mean or np.nanmean for datetime vectors?
I'm in favour of releasing even if we are currently broken with numpy master.
Our current release is also broken with numpy master, so the situation is no worse...
If someone could review and merge #3537 and #3531, we can close this!
I think we're good to go!
I agree! @crusaderky, @max-sixty: do either of you have the time to make a release?
Yup I can do it later this afternoon!
:+1:
Thanks @max-sixty I activated the RTD build.
Most helpful comment
I'm in favour of releasing even if we are currently broken with numpy master.
Our current release is also broken with numpy master, so the situation is no worse...