Xamarincommunitytoolkit: Add font options to Shield

Created on 22 Oct 2020  路  4Comments  路  Source: xamarin/XamarinCommunityToolkit

As proposed in the original PR, let's extend the Shield with all the font options

@sthewissen Sounds like a good idea to me, we can add FontFamily, FontSize and FontAttributes BindableProperties. Should include these properties in this PR or in a future iteration?

_Originally posted by @jsuarezruiz in https://github.com/xamarin/XamarinCommunityToolkit/pull/338#issuecomment-713467423_

Shield feature-request good-first-issue ready-to-implement up-for-grabs
Source
picture jfversluis

Most helpful comment

And let me know if can help with something :)

picture jsuarezruiz on 22 Oct 2020
❤2

All 4 comments

This sounds like a good plan :) I'm willing to take on this one and try to implement those extra options on the Shield control. If that's ok?! :)

jBijsterboschNL picture jBijsterboschNL on 22 Oct 2020
🚀1

image

jfversluis picture jfversluis on 22 Oct 2020
😄2

@jBijsterboschNL Remember to add the attribute [TypeConverter(typeof(FontSizeConverter))] on the FontSize properties
:smile:

485

471

Seuleuzeuh picture Seuleuzeuh on 22 Oct 2020
👍1

And let me know if can help with something :)

jsuarezruiz picture jsuarezruiz on 22 Oct 2020
❤2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

rdelrosario picture rdelrosario  路  3Comments
pictos picture pictos  路  7Comments
jsmarcus picture jsmarcus  路  5Comments
SunnyMukherjee picture SunnyMukherjee  路  3Comments
mallibone picture mallibone  路  6Comments