Xamarin.forms: [Bug] CommandBar content does not fill vertical space and shifts up when more (···) button is clicked

[velocitysystems]

Description

Content in the command bar ie. ToolBar item icons do not fill the available vertical space.
When the more (···) button on the toolbar is clicked, the content in the CommandBar shifts up.
Note: Only occurs when targeting UWP platforms > 16299.

May be related to #5661.

Steps to Reproduce

1. Create a blank Xamarin.Forms sample project with a UWP target.
2. Update to Xamarin.Forms 4.4.0 (vLatest) and target > 16299.
3. Add a page with one or more toolbar items.
4. Run the project on UWP and click the more (···) button.

Expected Behavior

The command bar should expand but not shift upward.

Actual Behavior

The command bar expands and shifts upward.

Basic Information

• Version with issue: 4.4.0 (vLatest)

• Last known good version:
  _N/A - Related to UWP platform change._
  https://github.com/microsoft/microsoft-ui-xaml/issues/275

• IDE: Microsoft Visual Studio 2019

• Platform Target Frameworks:
  
  
  
  • UWP: 1903 (or anything later than 16299)
  
  

Screenshots

Before

After

Reproduction Link

ToolbarIconSample.zip

[velocitysystems]

@jfversluis Hi Gerald. Do you know if this issue is fixed with https://github.com/xamarin/Xamarin.Forms/pull/8625?

[jfversluis]

@velocitysystems it might be! I've created a new build of that PR on top of master, you should be able to download the NuGet here: https://dev.azure.com/xamarin/public/_build/results?buildId=11995&view=artifacts&type=publishedArtifacts

Would you be able to try it?

[velocitysystems]

@velocitysystems it might be! I've created a new build of that PR on top of master, you should be able to download the NuGet here: https://dev.azure.com/xamarin/public/_build/results?buildId=11995&view=artifacts&type=publishedArtifacts

Would you be able to try it?

Thanks @jfversluis. I updated the repro project to use your NuGet artifact, however I get errors when trying to build as the .nupkg appears to be missing UWP payload files?

[apwillies]

We are seeing this on UWP too. Thanks in advance.

[velocitysystems]

@jfversluis Hi Gerald, just wondering if you possibly have any update on this? A number of of our UWP users are reporting it and it’s a little ugly to be sure. Thanks!

[jfversluis]

Unfortunately, I don't have any update to share at this moment, sorry about that. Is there anything from your side that you have discovered in the meantime that could help us get to the cause of this?

[JesseLiberty]

Confirmed that this still happens with Xamarin.Forms version 4.40.991265, Windows 10 version 1903. Check of web shows no fix for this yet

[velocitysystems]

Bump. Any possible updates on this?

[YZahringer]

Allow visibility configuration of Overflow button would be a solution? https://github.com/xamarin/Xamarin.Forms/issues/10885

[anpin]

Allow visibility configuration of Overflow button would be a solution? #10885

I would agree on this because on Android and iOS ToolbarItems / CommandBaritems are fully shown (despite the fact that target devices will usually have smaller screens). This is especially annoying if you need to port an existing app to UWP and the app has many pages with toolbar items with text only which will not be shown until you press the (···) button.

[pwillies]

@samhouts @PureWeen @hartez @jfversluis Hi XF Team, This is on our priority list too. It's also visual, but it affects every view in the app and looks very amateurish. It was reported back in December 2019.