Xamarin.forms: [Bug] Image animation not working in GTK

Created on 3 Dec 2019 · 29Comments · Source: xamarin/Xamarin.Forms

Description

It seems like image animation is not working in GTK. Similar code worked on the UWP backend.

Steps to Reproduce

https://github.com/ysangkok/XamarinGTKAnimationIssue

src.zip

Expected Behavior

Image should be animated.

Actual Behavior

Image is not animated.

Basic Information

Version with issue: 4.4.0.991210-pre2
Last known good version: don't know
Platform Target Frameworks: Ubuntu 18.04 with gtk-sharp 2.12.45-0xamarin17+ubuntu1804
Nuget Packages: See linked repository

image in-progress gtk bug

Source

ysangkok

All 29 comments

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

__This issue now has a funding of 1.045 ETH (150.03 USD @ $143.57/ETH) attached to it.__

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $76,903.23 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot on 12 Jan 2020

@izoch Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot on 17 Jan 2020

Commenting back

the-odd-hare on 18 Jan 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@izoch due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

[x] reminder (3 days)
[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot on 26 Jan 2020

@samhouts does this require work? Would like to work on it

mul53 on 11 Feb 2020

@mul53 what do you mean?

knocte on 15 Feb 2020

@knocte working on the bug

mul53 on 15 Feb 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

__Work has been started__.

These users each claimed they can complete the work by 1 week ago.
Please review their action plans below:

1) bobface has been approved to start work.

I can fix the bug with the animation.

Learn more on the Gitcoin Issue Details page.

gitcoinbot on 18 Feb 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

__Work for 1.045 ETH (272.64 USD @ $260.9/ETH) has been submitted by__:

@bobface

@knocte please take a look at the submitted work:

PR by @Bobface

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$82,169.00 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot on 20 Feb 2020

I tested this, with the sample project from the issue. It works, but it consumes 100% CPU and is not smooth. I am not sure whether this is a problem with this PR or with the sample project (which I made).

ysangkok on 24 Feb 2020

Hmm, would it be possible to link the image you have used?

Bobface on 24 Feb 2020

@ysangkok Also, the large the image the more expensive the calculation for scale & rotate. Did you test if it works smoothly with a small image, say 50x50?

Bobface on 24 Feb 2020

@Bobface I have a HiDPI monitor, so 50x50 is really small. But you are right that smaller sizes have less CPU load. For example, a 250x188 image runs with only 50% CPU utilization. I am using the ImageMagick logo image. To generate it in its full size (with width 500px), use convert logo: logo.png.

ysangkok on 25 Feb 2020

👍1

@Bobface maybe have a look at these answers: https://stackoverflow.com/questions/6888965/any-way-to-speed-up-reduce-cpu-usage-when-drawing-with-cairo?rq=1 :)

knocte on 25 Feb 2020

@ysangkok Okay, so the size of the image is definitely the problem.
@knocte Thanks, but it seems like I already do everything as described in that thread.

Bobface on 25 Feb 2020

Even the FPS reduction?

knocte on 25 Feb 2020

That should be achievable by reducing the frequency rate of the animation in @ysangkok 's repro (dummyFrequencyRate in LoadingPage.xaml.fs). However he links to another issue which says that that parameter is also not implemented in Xamarin.Forms and has no effect. Is that still correct @ysangkok ?

Bobface on 25 Feb 2020

@Bobface I have tested your PR 9856 with this one cherry-picked on top. Everything works as expected. Thank you.

ysangkok on 11 Mar 2020

🎉1

@ysangkok you mean CPU doesn't go to 100% anymore?

knocte on 12 Mar 2020

@knocte CPU consumption is not too high with reasonable animation update intervals and smaller image sizes, no.

ysangkok on 12 Mar 2020

👍1

Hi @ysangkok,

Is the fix provided by @Bobface working?

Solexplorer on 6 Apr 2020

@Solexplorer yes

ysangkok on 6 Apr 2020

@knocte Does this bounty also need review from maintainers?

Solexplorer on 6 Apr 2020

Yes but this should be merged only after PR 9856 is merged.

knocte on 6 Apr 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

__This issue now has a funding of 1.045 ETH (249.23 USD @ $238.5/ETH) attached to it.__

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Chat
- $307,869.71 more funded OSS Work available on the Gitcoin Issue Explorer