Xamarin.forms: [Bug] TextDecorations don't work

[davidortinau]

Description

Tested on iOS. I set underline or strikethrough on a label and nothing renders using 4.3.0 stable.

Basic Information

• Version with issue: 4.3.0
• Last known good version: ?
• Platform Target Frameworks:
  
  
  
  • iOS: 12.2, 13.1
  
  

Screenshots

Reproduction Link

https://github.com/davidortinau/fabriculous/blob/bug/decorations/Fabriculous/Pages/ButtonsPage.xaml#L42

[alanag13]

I noticed this while finishing up a different PR and noted the cause here. Definitely a regression, I might be able to fix when I close that PR up soon. https://github.com/xamarin/Xamarin.Forms/pull/4330#issuecomment-545731143

[davidbritch]

Other users have also discovered that TextDecorations don't work in 4.3, so it'd be good to get a fix out in a SR.

[akamud]

Just noticed this on my app on 4.3 too.

[Mikilll94]

I have also noticed that in my app.

Is there any workaround for this bug?

[tomahutbui]

same issue with 4.3 xf. version 4.2 work fine

[victorbotamedi]

@Mikilll94 a working workaround is to use a Span insetad. The TextDecorations of a span seems to be working fine

[APopatanasov]

What is the status of this issue? It's been logged from almost two months. Is a fix expected to be made soon?

The issue is affecting our image verification tests. The TextDecorations property is a top level property for the Label control and replacing Label with Span in every place we are using TextDecorations is not a very good option according to me.

[akamud]

I see this is not In progress anymore, no updates on the related PR or updates here. What's the status for the issue? Should we expect it in a 4.4 SR?

[davidbritch]

Also confirming that this still doesn't work on iOS, unless you use a Span.

[xleon]

Same stuff in 4.4

[Elinareso]

Hi everyone! Same issue here!!, We had to release our app with this issue. Is there a expected date to release this fix?

[BlueCoder77]

This is still broken in 4.4. When is a fix expected for this?

[quentinR0bert]

Any news about a fix in a 4.4 sr or 4.5 ?

[akamud]

The lack of ANY kind of support or message from a Xamarin team member in this issue really worries me.

[samhouts]

We're here! This should have been given more priority, but it got shuffled around and lost. It's unfortunate, but it happens. Next time, give me a ping, and I'll make sure we've got it appropriately prioritized.

In the meantime, I'll move this BACK to our sprint backlog, and hopefully we can get it resolved soon.

Thanks!

[PureWeen]

FYI this PR has fixes for this
https://github.com/xamarin/Xamarin.Forms/pull/4330

So we can finish that one up or extract the parts that at least fix this issue

[volcano619]

would this be fixed in the next release ?

[shidem]

Also confirming that this still doesn't work on iOS, unless you use a Span. Using Xamarin Forms 4.5.0.356. @samhouts This issue has languished for far too long IMHO.

[akamud]

Hi @samhouts, I'm afraid we are getting left in the dark here again. It has been over 1 month since the last update from the team, and again, I have no idea if this is being worked on or not.

[shidem]

@samhouts What do I need to do to escalate issue? It needs fixing! Nobody seems to be a paying attention except us. Boss wants answers, not workarounds.

[shidem]

I was being polite earlier, but now it's time to shout - "FIX IT NOW!!!!!"

[xleon]

@shidem I agree this should have been fixed already, but shouting with bad manners won't encourage anyone to do their job, but the oposite. This is an open source project and you are free to go and fix it yourself rather than crying like a baby.

[shidem]

@xleon @samhouts My humble apologies for shouting. But I do see a large number of PR's that have not been acted on. Also, Microsoft owns this and I appreciate the fact it is open sourced. My expectation is that things would continue improve. I let my frustration get the best of me. However, the frustration remains.

[Mikilll94]

@shidem @samhouts
The problem is that Xamarin team is constantly releasing new versions with new features while ignoring bugs from previous versions.

I prefer less features and more stability than opposite.

[shidem]

@xleon @samhouts @Mikilll94 I'm with ya Mikill! Not a buzz kill for me, but others have indicated massive code refactoring to incorporate the workaround @victorbotamedi proposed. I hope my posts escalate this issue to resolution and incorporation into the code base. A number of pull requests appear to be languishing; I suspect the maintainers/owners are overwhelmed and dealing with high impact issues first and getting those disseminated to the community.

I'd contribute to the effort, but others have already addressed the issue with their PR. I'm trying to reduce the noise and wave my hand to get the attention of the repo owners that issues need to be addressed, and then features.

[jsuarezruiz]

Alan's PR #4330 will fix this issue (and others). I will help and review the PR to merge it soon. In the meantime, I have created a fix for this specific issue https://github.com/xamarin/Xamarin.Forms/pull/10066 (only fix TextDecoration issue on iOS, nothing related with triggers and other platforms)

[EnglishDave]

This is still not working for Spans added to FormattedString and allocated to Label.FormattedText. using XF 4.8.0.1451 or XF 5.0.0.1487-pre1. Please re-open and provide a version estimate for when a fix will be available. Thanks.

[Cacuci]

I have same problem in Android. I am using Xamarin.Forms" Version="4.8.0.1364".

[WanftMoon]

Confirm, text decoration (strikethrough) for span on iOS not working.

[pursey]

Confirm, text decoration (strikethrough) for span on iOS not working.

I can also confirm this.

[volcano619]

This is still pending ??