Xamarin.forms: Xamarin Forms MasterDetailPage button padding issue in UWP

Created on 22 Mar 2019  路  19Comments  路  Source: xamarin/Xamarin.Forms

Description

I'm currently learning Xamarin Forms and I have a small graphic issue. I have to fit the height of all the buttons to 100% (based on Navigation bar). Actually Xamarin cut some pixels in the bottom for the hamburger icon and the "three dots" icon is not set to 100% height.

Steps to Reproduce

  1. Create xamarin form project with default template Master-Detail
  2. Modify UWP target version to 17763
  3. Run the app

Expected Behavior

image

Actual Behavior

image

Basic Information

  • Version with issue: UWP target Version 17763
  • Last known good version: UWP target Version 17134
  • IDE: Visual Studio 2017
  • Platform Target Frameworks:

    • UWP: The version of the UWP SDK 17763

Reproduction Link

Xamarin Forms MasterDetailPage button padding issue in UWP

2 in-progress high impact UWP bug

Most helpful comment

Please, fix this issue. I need to use newer UWP target version.

All 19 comments

Hi, Is there any progress on this issue?

I'm running in to this too. The padding was off as described above directly from the template, with no code modifications on my part.

Is there any sort of workaround?

UWP target 18362 also has this issue

same here.
Target Version 18362 (1903)
Min Version 17134 (1803)

When you press the ellipsis button on the side, it moves the content of the entire header to a partially invisible area:

image

I'm running in to this too. The padding was off as described above directly from the template, with no code modifications on my part.

Is there any sort of workaround?

You could set your UWP target version as 17134 to avoid this behavior.

Please, fix this issue. I need to use newer UWP target version.

Another reproduction. Note that the size of the ToolbarItem icon also changes with the target upgrade from 17134 to 17763.

uwp_toolbar

The listed workaround (setting target SDK to earlier version) no longer works with latest xamarin.forms v4.3. I tried all the SDK's back to fall creators update build 16299, all have menu button cut off now and it looks very unprofessional. Truly a showstopper....

@PureWeen @samhouts We note that when using XF 4.2, setting the target version to 1803 or lower resolves this issue. However in XF 4.3, this no longer works.

We noticed that in #7719 you mention the SDK version is being rolled back to 16299.
Will this be available in XF 4.3-sr2? Will this work for us as we target 1903 in our project?

Note: We are currently running XF 3.4.x in production successfully _without_ this issue.

I think the priority of this should be increased, as there is currently no workaround available. It looks really bad and I'd rather not release a UWP app with this.

@davidortinau David, this is a significant regression for users with apps running on UWP.
Could you please advise if there a timeframe on when we can expect a fix?

We love XF 4.3 and are working on adopting many of the new features available, but this issue is currently blocking us from releasing an update to our production users.

Thanks so much and we appreciate the hard work of the XF team.
--Matthew

I think you should be able to fix it by adding this to your App.xaml in your UWP project

<Application.Resources>
    <x:Double x:Key="AppBarThemeCompactHeight">48</x:Double>
</Application.Resources>

At least the padding in the regular view disappears. Still something funny seems to be going on when you press the ellipsis button though.

I'm still trying to figure out what is going on with the different combinations of UWP SDKs, XF NuGets, etc.

I think you should be able to fix it by adding this to your App.xaml in your UWP project

<Application.Resources>
    <x:Double x:Key="AppBarThemeCompactHeight">48</x:Double>
</Application.Resources>

At least the padding in the regular view disappears. Still something funny seems to be going on when you press the ellipsis button though.

I'm still trying to figure out what is going on with the different combinations of UWP SDKs, XF NuGets, etc.

This sort of fixes the problem. Sadly no matter what UWP target I use, toolbar items are still not sized properly on XF 4.3.~.

Any news on the status of this issue?

This seems to be working correctly for me now with XF 4.3.0.991221

@lordalcol and all this should be fixed with merging #8610 which should be available now in the latest 4.3 and 4.4 package. I'm closing this one, if there is still something wrong, please open a new one referencing this one.

Thanks!

I still see this issue with the latest XF Version.
XF: 4.3.0.991221
UWP SDK: 10.0.18362.0

The toolbar button height is wrong:
image

Hello, is there any progress towards solving this problem?

@samhouts the issue persists in XF 4.6.0.847 and #8625 is closed. Should this issue be reopened?

Was this page helpful?
0 / 5 - 0 ratings