Xamarin.forms: [Android] ImageButton on android is not clipping view to corner radius

[PureWeen]

Description

I'm using the new ImageButton control introduced with XF 3.4 to create circular image button. Unfortunately it doesn't work on Android.

it looks like the rounding on Android will need to be achieved by utilizing canvas.drawcircle inside the Draw method. So the paint object and all the parameters for that will need to be setup and used instead of base.draw

Steps to Reproduce

<ImageButton Grid.Row="0" Grid.Column="0" Source="{Binding ProfileImage, Converter={StaticResource PathToImageConverter}}" CornerRadius="50" HorizontalOptions="Center" VerticalOptions="Center" HeightRequest="100" WidthRequest="100"> </ImageButton>

Or run the ControlGallery Issue G1724 which demonstrates a circular button.

Expected Behavior

See a circular image

Actual Behavior

Image is rectangular

Basic Information

• Version with issue: 3.4.0.1008975
• Last known good version: N/A
• IDE: VS 2017 Professional 15.9.2
• Platform Target Frameworks:
  
  
  
  • iOS: 12.0 (16A366)
  
  
  • UWP: 16299
  
  
  • Android: 9.0
  
  
• Nuget Packages:
• Affected Devices:

Screenshots

Android

UWP

Reproduction Link

[syed-pelican]

Need this fix badly :(
Plus some mmaterial shadow underneath will be awesome!

[PureWeen]

I want to live Sambot!!!

[CARP-Kaiser]

When will this fix be available?

[CARP-Kaiser]

@samhouts Why does this say closed when it hasn't come out in the past 3 releases?

[samhouts]

Issues are closed when they are merged, not when they are released. This was merged into master, so it will be part of 4.5.0. @PureWeen is this fix suitable for a backport to 4.4.0?

[PureWeen]

@samhouts Yes! I'll backport it to 4.4.0 so it'll be part of the next SR of 4.4.0

[CARP-Kaiser]

You both are awesome. @samhouts thank you for the describing the difference between the two.

[CARP-Kaiser]

@PureWeen @samhouts Thanks you guys for your hard work. Fix works like a charm.