Xamarin.forms: PushModalAsync not modal on WPF

Created on 10 Jul 2018  路  8Comments  路  Source: xamarin/Xamarin.Forms

On WPF, when a modal page is invoked like this:

c# sourcePage.Navigation.PushModalAsync(new NavigationPage(modalRoot));

The resulting page is not modal. It has a back button, and the toolbar in the navigation page is not displayed, which is opposite of the expected results.

Xamarin.Forms.Platform.WPF 3.1.0.583944

4 WPF bug

Most helpful comment

I have this fixed and am working on a pull request. As mentioned by woody3k it was syncing to the wrong FormsPage- but then also the PART_ModalContentControl was being displayed over the navigation bar.

All 8 comments

Described behavior confirmed using 3.1

It is a modal page but I still put the back button. I can delete the back button.

But I confirm that the navigation bar is missing in the modals pages

Any updates on this one?
I have a couple of modal settings dialogs with buttons on the toolbar to apply changes - without the toolbar the dialogs obviously don't work.
Thanks for your work on the WPF!
Xamarin Forms v3.5.0.12952

Dug into this very briefly to understand the current behaviour. It looks like when a page is pushed modally, it triggers the window navigation bar to synchronize (FormsWindow.SynchronizeAppBar). However this attempts to synchronize to the first visual child page (which will probably be the topmost page of the main window's root page), and doesn't consider pages that might have been add later (modal pages).

I have this fixed and am working on a pull request. As mentioned by woody3k it was syncing to the wrong FormsPage- but then also the PART_ModalContentControl was being displayed over the navigation bar.

Still no navigation bar on modal pages for WPF :(

This issue doesn't seem to have had any activity in a long time. We're working on prioritizing issues and resolving them as quickly as we can. To help us get through the list, we would appreciate an update from you to let us know if this is still affecting you on the latest version of Xamarin.Forms, since it's possible that we may have resolved this as part of another related or duplicate issue. If we don't see any new activity on this issue in the next 30 days, we'll evaluate whether this issue should be closed. Thank you!

Yes, it's still an issue.

Was this page helpful?
0 / 5 - 0 ratings