Xamarin.forms: RTL doesn't switch the margin

[RadwanIbrahim]

Description

switch from LTR to RTL doesn't mirror the margin

Steps to Reproduce

1. add the below XAML to a content page and check the result
   `

   <Label Text="LeftToRight"
          Margin="10" />
   <Grid FlowDirection="LeftToRight">
       <BoxView Margin="50,0,0,0"
                WidthRequest="100"
                HeightRequest="100"
                Color="Red"
                HorizontalOptions="Start"
                VerticalOptions="Start"
                FlowDirection="LeftToRight" />
   </Grid>
   <Label Text="RightToLeft"
          Margin="10" />
   <Grid FlowDirection="RightToLeft">
       <BoxView Margin="50,0,0,0"
                WidthRequest="100"
                HeightRequest="100"
                Color="Red"
                HorizontalOptions="Start"
                VerticalOptions="Start"
                FlowDirection="RightToLeft" />
   </Grid>
   

   `

Expected Behavior

switching from LTR to RTL Should mirror the margin

Actual Behavior

switching from LTR to RTL doesn't mirror the margin

Basic Information

• Platform Target Frameworks:

  • iOS:
  • Android:
  • UWP:

• Nuget Packages:
  xamarin forms 3

Screenshots

current state

desired state

Reproduction Link

RTLMarginIssue.zip

[AmrAlSayed0]

Friendly nudge here, is there any plan for this issue? I looked at #1222 but there was no mention of Padding and Margin.

Also, why is this issue labeled Enhancement rather than Bug? I mean it seems acceptable that if the flow direction was to reverse the padding and margin should too. I can't think of a case where you wouldn't want that behavior. Of course, I could be wrong.

[danielkatz]

@radekdoulik The issue is actually worse because Padding does respect the element's FlowDirection, while Margin does not.

Given this, IMO @AmrAlSayed0 is right, and this should qualify as a bug, and the title of the issue should be corrected.

To workaround this issue on our project i've come up with RtlThickness.
The project also includes a demo of the issue and the solution with a comparison between Margin and Padding.

[RadwanIbrahim]

@samhouts we appreciate if you could mark this as bug not enhancements as we cant use RTL Without doing workaround to fix this

[samhouts]

This issue doesn't seem to have had any activity in a long time. We're working on prioritizing issues and resolving them as quickly as we can. To help us get through the list, we would appreciate an update from you to let us know if this is still affecting you on the latest version of Xamarin.Forms, since it's possible that we may have resolved this as part of another related or duplicate issue. If we don't see any new activity on this issue in the next 30 days, we'll evaluate whether this issue should be closed. Thank you!

[AmrAlSayed0]

@samhouts I have already submitted a PR #11469 to fix this issue and it is targeted on 5.0.0 branch. Up until I fixed it, the issue was still there.