Wysiwyg-editor: [Feature proposal] Image caption

[pkhruasu-ui]

Due to my work related's task I had to extend image capabilities to be able to add image caption.
So far I belive that I am able to do that and cover most of the side effects that occur.

So to my question, how do I hand off this change to Froala team so that they can take a look and, if possible, fix any oversight and integrate it into the official plugin?

Ex:

[stefanneculai]

Thank you for the suggestion. Image figure is on our TODO list already. We do not keep feature requests here on Github, therefore I am closing it for now.

[pkhruasu-ui]

Oh that is great to know it is on TODO list. Is it possible to tell when this feature is available?

[stefanneculai]

We don't have an ETA for it at this moment.

[Floriskoch]

@pkhruasu-ui would you mind sharing your work? I'm looking to build similar functionality, thanks!

[pkhruasu-ui]

@Floriskoch here is the file. It is v2.4.2.
froala-image-caption-2-4-2.txt

[stefanneculai]

Just a quick update here. The last commit is adding image caption feature.

[pkhruasu-ui]

Perfect. Thanks so much for letting use know. How do we add it?

[stefanneculai]

Just update to version 2.7.0 and you'll find it in the Image Edit popup. There is also a demo on our website: https://www.froala.com/wysiwyg-editor.

[pkhruasu-ui]

Perfect. Many thanks and great jobs!!

On Tue, Sep 19, 2017 at 12:31 AM, Stefan Neculai [e-mail]
wrote:

Just update to version 2.7.0 and you'll find it in the Image Edit popup.
There is also a demo on our website: https://www.froala.com/wysiwyg-editor
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/froala/wysiwyg-editor/issues/1828#issuecomment-330454692,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF_fTaAUn1krZv90uFMrK1YS9s9EVq3cks5sj23hgaJpZM4MZtja
.

[aaclayton]

Hi Froala, thanks a lot for adding image caption support, however, I am wondering why you did not opt to use a more semantic HTML specification for the elements. For example (using the demo on the website)

<p style="text-align: center;">
    <span class="fr-img-caption fr-fir fr-dii" style="undefined">
        <span class="fr-img-wrap" style="width: 200px;">
            <img width="200" src="https://cdn0.froala.com/assets/editor/pages/B/editor-photo-645d411798e5b4e825765d091dd5aaab.jpg" alt="Editor photo">
            <span class="fr-inner">This is a caption</span>
        </span>
     </span>
</p>

It seems to me that this should have been done by using the figure and figcaption semantic elements, instead of awkwardly using span for everything. For example, something like:

<p style="text-align: center;">
    <figure class="fr-img-caption fr-fir fr-dii">
        <img width="200" src="https://cdn0.froala.com/assets/editor/pages/B/editor-photo-645d411798e5b4e825765d091dd5aaab.jpg" alt="Editor photo">
        <figcaption class="fr-inner fr-caption">This is a caption</figcaption>
    </figure>
</p>

Do you have some intuition for why relying on <span> instead of more semantic elements is the best way to go?

Thanks,
Andrew

[dianaprajescu]

Sure, @aaclayton. Using span instead of figure is quite a debated topic, both internally and among Froala Editor users. Please check out issue #2206 for more details.

[aaclayton]

Hi @dianaprajescu, thanks for the link, was informative. I understand having read the related ticket why the span decision was made, and I'm glad to hear that <figure> support will be considered for a future major version.

One possible approach might be to add a configuration option to the image plugin that would allow the user to chose their caption style without forcing existing users into the change. Obviously, adding conditional support increases code complexity, but it might be a good way to collect more data before making a final decision.

[jEnbuska]

Any update on this?