Www.rust-lang.org: Frontend cleanup: Remove Skeleton

[skade]

Supersedes #183

The Rust website currently uses two CSS frameworks: Skeleton and Tachyons (http://tachyons.io/docs/layout/flexbox/). This is due to an unfinished migration. This unfinished migration is a blocker for further extensions of the website.

We'd like to completely move over to Tachyons. There's two wishes here:

• We should avoid tachyons _grid_ and instead us its flexbox classes: http://tachyons.io/docs/layout/flexbox/
• If possible, elements of similar shape should use the same code.

It's easy to help out! Here are some instructions:

• Check out the website
• Pick _one_ of the subpages
• Post here that you care for that subpage. You will have 7 days to post a PR (otherwise, we'll ping you)
• (optional) join https://discord.gg/rust-lang and go to #website if you need help or feedback.
• remove skeletons from the page: https://github.com/rust-lang/www.rust-lang.org/pull/774/files
• Fix what's broken, using Tachyons or custom CSS. Also try to thoroughly remove now unused CSS classes.
• Optional: check this bugtracker for issues concerning you page and try to fix them on the go

Handy page list for everyone to check:

| URL | Page Name | Assigned | Fixed
| --- | --- | --- | ---
| / | Index | @dzhibas | yes
| /install | Install | @andirotter | yes
| /learn | Learn | @Pjb518 | yes
| /tools | Tools | @dzhibas | yes
| /governance | Governance | @dzhibas | yes
| /community | Community | @yayoc | yes
| /what | What | @skade | yes
| /what/cli | CLI | @skade |
| /what/embedded | Embedded | @skade |
| /what/wasm | WASM | @skade |
| /what/networking | Server | @dzhibas | yes
| /what/production | Production | @dzhibas | yes
| /policies | Policies | @chriskrycho | yes
| /policies/media-guide | Media Guide | @chriskrycho | yes
| /policies/security | Security | @chriskrycho | yes
| /policies/license | License | @chriskrycho | yes
| /policies/code-of-conduct | Code of Conduct | @chriskrycho | yes

[andirotter]

Hey there,

i will start with the "Install" subpage. Also heading over to the discord chat for questions that might arose.

[Pjb518]

Hey,

I've actually almost completed the Learn page. This includes a lot of site-wide styles, such as the headers and the footer code.

[skade]

Thanks! @Pjb518 and @andirotter!

[wizofe]

I can get the what/embedded page :)

[skade]

@wizofe go ahead. Note that @Pjb518 got header and footer ported, no need to invest time there!

[eatrero]

~Hi, I can help out on the /policies page~ Already done https://github.com/rust-lang/www.rust-lang.org/pull/362

[Pjb518]

@wizofe go ahead. Note that @Pjb518 got header and footer ported, no need to invest time there!

The section headings and global font size has also already been taken care of, so most of the changes now should be layout issues.

[yayoc]

Hi, I can get /community page.

[skade]

@yayoc yay! :tada:

[dzhibas]

/tools PR https://github.com/rust-lang/www.rust-lang.org/pull/787

@skade i don't see /contribute route available

[dzhibas]

404 NotFound template fix https://github.com/rust-lang/www.rust-lang.org/pull/788

after 404 and tools i ran this ripgrep through templates

$ cd templates && rg "columns" -l

production/index.hbs
components/panels/production.hbs
components/what/wasm/production.hbs
components/what/wasm/pitch.hbs
components/what/wasm/js.hbs
components/what/wasm/get-started.hbs
components/what/embedded/testimonials.hbs
components/what/embedded/showcase.hbs
components/what/cli/production.hbs
components/what/cli/example.hbs
components/what/networking/pitch.hbs
components/what/networking/production.hbs
components/what/networking/get-started.hbs

[skade]

@dzhibas Indeed, the /contribute page doesn't exist anymore (I thought I caught all of them when I copied the list)

[lwshang]

I suggest to have some extra columns in the table which show the current status (like Open, In Development, Done) of a page and maybe who contributed to or is working on that page. That will make it easy to track the progress.

[dzhibas]

totally agree @lwshang , at this point it's hard to track whats left and where people can jump in and still contribute

[skade]

I changed the list above. Anything more complex would probably need breaking things up into tickets.

[skade]

Opened PRs for the last pages, we should be able to remove skeletons over this weekend \o/.

There's a few outstanding issues, but they were there before.

[skade]

I posted a final PR here: https://github.com/rust-lang/www.rust-lang.org/pull/833. Thanks @dzhibas @yayoc @Pjb518 @wizofe @eatrero @andirotter

[skade]

Done.