ws.send method should support objects too

[ZaDarkSide]

This code works:

ws.send(JSON.stringify({test: 'test'}));

This doesn;t:

ws.send({test: 'test'});

I propose an enhancement in Sender.js to allow or convert objects automatically.

[3rd-Eden]

Sending JSON would make no sense as it would not be decoded automatically on a WebSocket client.

[ZaDarkSide]

You are right, but instead of throwing an error like this one:

"TypeError: First argument must be a string, Buffer, ArrayBuffer, Array, or array-like object."

Maybe instead the error message should be improved at least something like:
"If you are trying to send a object please serialize it first with your method of choice, JSON, BSON, etc."

Related with https://github.com/HenningM/express-ws/issues/72

[lpinca]

That error is thrown by Node.js when you try to make a buffer from an object.

Buffer.from({ test: 'test' });

The WebSocket protocol only works with text and binary data so anything regarding SerDes should not be handled by this lib.

[ZaDarkSide]

Yes I understand, but in Sender.js there is already some code that does conversion from ArrayBuffer to Buffer, why not add conversion from Object to Buffer also?

[lpinca]

That's already binary data, we have to convert to it Buffer because that's the "type" required by Node.js API and to know the length in bytes of a string.

[ZaDarkSide]

Okay, it's a minor issue for me, closing this.

[zvictor]

It is great that I find this issue, though. I couldn't figure out what I was doing wrong... Thanks for posting @ZaDarkSide !