Wpt: META.yml: Replace ayg in suggested_reviewers

Created on 15 Jun 2018  路  19Comments  路  Source: web-platform-tests/wpt

@ayg has not accepted the invite, but appears in a number of META.yml files. Consider removing and adding someone else.

$ git grep "  - ayg"
dom/META.yml:  - ayg
editing/META.yml:  - ayg
html/dom/META.yml:  - ayg
html/editing/META.yml:  - ayg
html/infrastructure/META.yml:  - ayg
html/obsolete/META.yml:  - ayg
html/semantics/META.yml:  - ayg
resources/META.yml:  - ayg
selection/META.yml:  - ayg

files that include only ayg

$ git grep -l "  - ayg" | xargs wc -l | grep "2 "
       2 editing/META.yml
       2 html/dom/META.yml
       2 html/editing/META.yml
       2 html/infrastructure/META.yml
       2 html/obsolete/META.yml
       2 html/semantics/META.yml
       2 selection/META.yml

Since html/META.yml exists, the html ones could be removed. That leaves editing and selection.

needs-reviewers

Most helpful comment

Suggestion based on the above:

Path | Suggested reviewers
---|---
./the-root-element | @darobin
./text-level-semantics | @jeisinger
./disabled-elements | ~@Ms2ger~
./sections | @darobin
./forms | @tkent-google
./common-idioms | @darobin
./scripting-1 | @domenic
./tabular-data | @tkent-google
./links | @annevk
./embedded-content | @foolip @zcorpan
./grouping-content | @domenic
./edits | ~@Ms2ger~
./interactive-elements | @foolip
./selectors | @lilles @zcorpan
./document-metadata | @bzbarsky

Please respond if you're OK with being asked for review for the above dirs.

All 19 comments

@rniwa can you take selection?

@johanneswilm can you take editing?

I can take html/obsolete, just my kind of thing.

html/semantics is very broad, is there really anyone who would be a good reviewer for all of it?

If nobody steps up, we could split html/semantics in some manner between you, me, @annevk and @domenic. WDYT?

Yeah, I'd be fine with with most of html/semantics/embedded-content/. Here are the numbers of files in the directories:

2 disabled-elements
2 the-root-element
6 common-idioms
9 edits
15 sections
22 links
26 selectors
27 interactive-elements
44 tabular-data
72 grouping-content
86 document-metadata
88 text-level-semantics
253 forms
495 scripting-1
779 embedded-content

Here are the 5 most recent commit authors for each dir under semantics:

semantics zcorpan$ find . -type d -depth 1 | while read line ; do echo $line; git log -r -5 --format="%an %ae" $line ; done
./the-root-element
Robin Berjon [email protected]
./text-level-semantics
Bhagirathi Satpathy [email protected]
Bhagirathi Satpathy [email protected]
Bhagirathi Satpathy [email protected]
Bhagirathi Satpathy [email protected]
Jochen Eisinger [email protected]
./disabled-elements
Ms2ger [email protected]
Denis Ah-Kang [email protected]
Denis Ah-Kang [email protected]
Denis Ah-Kang [email protected]
Robin Berjon [email protected]
./sections
Robin Berjon [email protected]
./forms
Mike Pennisi [email protected]
Kent Tamura [email protected]
Anne van Kesteren [email protected]
TAMURA, Kent [email protected]
Rune Lillesveen [email protected]
./common-idioms
Robin Berjon [email protected]
./scripting-1
Simon Pieters [email protected]
Stephen McGruer [email protected]
Domenic Denicola [email protected]
Mike Pennisi [email protected]
Domenic Denicola [email protected]
./tabular-data
kaixinjxq [email protected]
[email protected] [email protected]
David Grogan [email protected]
Aryeh Gregor [email protected]
Jessica Jong [email protected]
./links
Anne van Kesteren [email protected]
Anne van Kesteren [email protected]
charlesvdv [email protected]
Boris Zbarsky [email protected]
Geoffrey Sneddon [email protected]
./embedded-content
Ehsan Karamad [email protected]
Simon Pieters [email protected]
Emilio Cobos 脕lvarez [email protected]
Emilio Cobos 脕lvarez [email protected]
Mike Pennisi [email protected]
./grouping-content
Emilio Cobos 脕lvarez [email protected]
Quinten Yearsley [email protected]
Domenic Denicola [email protected]
Petr Gazarov [email protected]
Domenic Denicola [email protected]
./edits
Ms2ger [email protected]
Zhiqiang Zhang [email protected]
Robin Berjon [email protected]
./interactive-elements
Dave Tapuska [email protected]
Shanmuga Pandi M [email protected]
Philip J盲genstedt [email protected]
Shanmuga Pandi M [email protected]
Shanmuga Pandi M [email protected]
./selectors
Rune Lillesveen [email protected]
Rune Lillesveen [email protected]
Rune Lillesveen [email protected]
[email protected] [email protected]
[email protected] [email protected]
./document-metadata
Anthony Ramine [email protected]
Rakina Zata Amni [email protected]
Boris Zbarsky [email protected]
Boris Zbarsky [email protected]
Boris Zbarsky [email protected]

@foolip can you look into translating these to GitHub usernames?

I don't have any special tricks apart from people who work at Google, what I'd do is to look at a commit for each name I don't already recognize, and see what username GitHub attributes it to. Rune is lilles, for example.

(Actually a bad example, since I used the Googler lookup tool for that one.)

Using https://github.com/sindresorhus/github-username-cli

$ cat emails.txt | while read line; do echo $line; github-username $line --token=...; done
[email protected]
annevk
[email protected]
ayg
[email protected]
TypeError: Cannot read property 'login' of null
[email protected]
bzbarsky
[email protected]
charlesvdv
[email protected]
domenic
[email protected]
deniak
[email protected]
davidsgrogan
[email protected]
dtapuska
[email protected]
ehsan-karamad
[email protected]
emilio
[email protected]
TypeError: Cannot read property 'login' of null
[email protected]
gsnedders
[email protected]
jessi3py
[email protected]
jeisinger
[email protected]
jugglinmike
[email protected]
Ms2ger
[email protected]
nox
[email protected]
petrgazarov
[email protected]
foolip
[email protected]
qyearsley
[email protected]
rakina
[email protected]
darobin
[email protected]
TypeError: Cannot read property 'login' of null
[email protected]
shanmuga-m
[email protected]
stephenmcgruer
[email protected]
tkent-google
[email protected]
kaixinjxq
[email protected]
zcorpan
[email protected]
TypeError: Cannot read property 'login' of null

Yes, I can take editing.

I can take scripting-1 and probably other stuff. I nominate @tkent-google as reviewer for forms, if he's interested.

Suggestion based on the above:

Path | Suggested reviewers
---|---
./the-root-element | @darobin
./text-level-semantics | @jeisinger
./disabled-elements | ~@Ms2ger~
./sections | @darobin
./forms | @tkent-google
./common-idioms | @darobin
./scripting-1 | @domenic
./tabular-data | @tkent-google
./links | @annevk
./embedded-content | @foolip @zcorpan
./grouping-content | @domenic
./edits | ~@Ms2ger~
./interactive-elements | @foolip
./selectors | @lilles @zcorpan
./document-metadata | @bzbarsky

Please respond if you're OK with being asked for review for the above dirs.

Those are OK for me.

I'm fine with forms and tabular-data.

Please drop me (unless someone wants to pay me to review those tests).

There's only 1 test in disabled-elements and 2 in edits, so maybe we can just leave those without reviewers and let it fall back to html/META.yml.

OK.

You can add me as a suggested reviewer for selection tests.

I can do document-metadata, I guess. Availability may be somewhat limited, though...

Was this page helpful?
0 / 5 - 0 ratings