Wpf: What is PBTCOMPILER? Is it redundant?

[hughbe]

There are a lot of ifdefs for PBTCOMPILER in the codebase. Are these redundant? What does this check for?

[rladuca]

@hughbe Good question. PBTCOMPILER is for PresentationBuildTasks.dll. That DLL contains MarkupCompilePass1/2 which are MSBuild tasks that build XAML. That component is not yet released as open source, but shares some code with System.XAML. The ifdefs are indeed needed.

[vatsan-madhavan]

Not redundant - it refers to PresentationBuuldTasks.dll’s main conditional compilation symbol.

In general, avoid changing conditionally compiled code very much. There are some source files that had to be copied over to github while being maintained in the closed version separately because they are shared across multiple binaries. Over time we’ll end up with all sources in the same repo(github), but for now, we’d like to minimize coherency problems as much as possible - so we’d like to minimize (or avoid) churn to code blocks with conditional compilation (and to files with conditional compilation).

[hughbe]

Thanks for the quick response! Would be nice if we could document these ifdefs and hint they shouldn’t be removed m (If there’s never a plan to open source the library using it), or we can close this issue :)

[stevenbrix]

We defintely are planning on open sourcing the code very soon!