Wpf: XMLNS sweep to ensure parity with desktop framework

[rladuca]

• .NET Core Version: (e.g. 3.0 Preview1, or daily build number, use dotnet --info) All
• Windows version: (winver) All

• Does the bug reproduce also in WPF for .NET Framework 4.8?: No

  Problem description:
  WPF is missing various xmlns attributes in its reference assemblies. We need to sweep all of them to ensure we pick everything up.
  Actual behavior:
  N/A
  Expected behavior:
  N/A
  Minimal repro:
  See the various related issues.

[rladuca]

We've completed the sweep and we were missing both WindowsBase and System.Xaml reference assembly XMLNS attributes.

I'll update when I am sure the fixes have made the daily builds.

[taori]

@rladuca just checking - forgot to update, or no updates yet? Currently trying to compile for netcore3.0 and XmlnsDefinitionAttribute + XmlnsPrefix is missing.

[rladuca]

@taori I want to make sure I understand, are you saying the attributes themselves are missing?

I just created a new .NET Core 3 project and I was able to add XmlnsDefinition and also XmlnsPrefix, they both were under System.Windows.Markup as expected. Cracking open the binaries from the latest nightly, I see them defined there as well.

Is there a reproduction application you can link me to just so I can get a better idea of what is going on?

[rladuca]

Also this issue should have been closed, I forgot to do so when the daily build had updated.

@taori I'll keep this open in case I missed something, but if it's not the same problem, we might shift to opening a new issue.

[taori]

@rladuca https://github.com/taori/Amusoft.UI.WPF.git , src/Amusoft.UI.WPF/Amusoft.UI.WPF.csproj did not compile with netcoreapp3.0 - perhaps i am on a different sdk build which is not public yet ofc. If so - is there an alternative download source other than https://dotnet.microsoft.com/download/dotnet-core/3.0, where i can obtain an installer?

Using the latest sdk on the download site provides me with this:

[taori]

I figured out why -

my csproj had

<Project Sdk="Microsoft.NET.Sdk">

instead of

<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">

After changing it, it compiled just fine.

[ccifra]

The issue I was seeing was that using x:Reference in XAML would fail with a compile error.

For example using this XAML in the default WPF .net core app fails to compile with Preview 1:

xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:local="clr-namespace:TestXReference"
mc:Ignorable="d"
Title="MainWindow" Height="450" Width="800">





FontSize="40"/>

This works fine with desktop WPF. Can I try the most recent SDK to test things out? Will preview 2 have the fix?

--Chris

From: Rob LaDuca [e-mail]
Sent: Monday, January 14, 2019 8:14 PM
To: dotnet/wpf [e-mail]
Cc: Christopher Cifra [e-mail]; Manual [e-mail]
Subject: Re: [dotnet/wpf] XMLNS sweep to ensure parity with desktop framework (#119)

@taorihttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftaori&data=02%7C01%7C%7Cfd5a6a7f20b04132db6808d67a8f2124%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636831152550279690&sdata=kZpo96HamyD3wl7oshmKYn2Y2Tta4pgh%2FDNjASHunFE%3D&reserved=0 I want to make sure I understand, are you saying the attributes themselves are missing?

I just created a new .NET Core 3 project and I was able to add XmlnsDefinition and also XmlnsPrefix, they both were under System.Windows.Markup as expected. Cracking open the binaries from the latest nightly, I see them defined there as well.

Is there a reproduction application you can link me to just so I can get a better idea of what is going on?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fwpf%2Fissues%2F119%23issuecomment-454242061&data=02%7C01%7C%7Cfd5a6a7f20b04132db6808d67a8f2124%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636831152550279690&sdata=Jg5vrk0MGxPRNS4gtlKLvLVj2yFUdY0M%2F4JZBd1yJzM%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADWm4l1j1msobLn6gIW3tnpvM4q1kLD5ks5vDTlvgaJpZM4ZIwbZ&data=02%7C01%7C%7Cfd5a6a7f20b04132db6808d67a8f2124%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636831152550279690&sdata=tReiTh96dLVJ%2BSiZDI67Xn9zewrY4EELVC1XLTIS%2BKI%3D&reserved=0.

[radiy]

Same here x:Reference still missing. Sdk version 3.0.100-preview-010086.

[rladuca]

@taori That happens, having to consider the implicit references via the SDK is a new thing for a lot of WPF developers. Glad to hear it works.

@radiy and @ccifra, I'll take a look today at x:reference.

[rladuca]

This is my mistake in my previous change, I didn't add the file to the build correctly. Apologies, this should be fixed in daily builds a few days from now. I believe this fix will also make Preview 2.

[rladuca]

You should now see this fix in the latest daily build (3.0.0-preview-27315-14) of the WindowsDesktop SDK.

I was able to compile with x:Reference without issue on that build.

@radiy and @ccifra if you can confirm that you're good to go, I'll close this. Thanks!

[radiy]

@rladuca Thank you, finally something compiles.

[rladuca]

This is in both the latest daily builds and will make it into Preview 2, so I am going to close this.

Feel free to comment and ping me if you think there is more to fix.

[ccifra]

This still seems to be an issue with Preview 2:

[cid:[email protected]]
[cid:[email protected]]
Did it definitely make it in?

--Chris

From: Rob LaDuca [e-mail]
Sent: Friday, January 18, 2019 10:15 AM
To: dotnet/wpf [e-mail]
Cc: Christopher Cifra [e-mail]; Mention [e-mail]
Subject: Re: [dotnet/wpf] XMLNS sweep to ensure parity with desktop framework (#119)

This is in both the latest daily builds and will make it into Preview 2, so I am going to close this.

Feel free to comment and ping me if you think there is more to fix.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fwpf%2Fissues%2F119%23issuecomment-455600925&data=02%7C01%7C%7Cb4321fde2e6647201e1108d67d602059%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636834249136718009&sdata=WD1f3Jqk04faiX1Ig2rL2QnxgiUaZVtYNsuJkINgroY%3D&reserved=0, or mute the threadhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADWm4jHnP8W_r14xqdk2EMblsEkSTKzZks5vEfMQgaJpZM4ZIwbZ&data=02%7C01%7C%7Cb4321fde2e6647201e1108d67d602059%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636834249136718009&sdata=MzpIG0D3OHViacrJqVRg1mzx0MQOXNIPy4KurJyfIrg%3D&reserved=0.

[rladuca]

@ccifra I installed the latest daily build of .NET Core 3 and was able to compile and run the sample code that you pasted with no issue.

I cracked open both the installed shared framework lib binary and the ref assembly from the corresponding nuget package. Both contain the XML namespace definitions. This was checked in early enough to snap to Preview 2 builds (there is no officially released Preview 2 yet) so it will be out with that as well.

Are you sure you're using the latest daily builds? I can't see what you posted as the error condition.

[ccifra]

To close the loop on this. I thought that the Visual Studio Preview 2 include the .net core preview 2. My mistake. I did test our code against the latest daily build of .net core and this issue does appear to be fixed.

Thanks,
--Chris

From: Rob LaDuca [e-mail]
Sent: Thursday, January 24, 2019 11:40 AM
To: dotnet/wpf [e-mail]
Cc: Christopher Cifra [e-mail]; Mention [e-mail]
Subject: Re: [dotnet/wpf] XMLNS sweep to ensure parity with desktop framework (#119)

@ccifrahttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fccifra&data=02%7C01%7C%7C94bc584684294a324a1b08d68222fcac%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636839484105588899&sdata=%2BBP0j%2BPFdgBQ451ChojE9EI8fmVLh4XXwOh1ltVZugY%3D&reserved=0 I installed the latest daily build of .NET Core 3 and was able to compile and run the sample code that you pasted with no issue.

I cracked open both the installed shared framework lib binary and the ref assembly from the corresponding nuget package. Both contain the XML namespace definitions. This was checked in early enough to snap to Preview 2 builds (there is no officially released Preview 2 yet) so it will be out with that as well.

Are you sure you're using the latest daily builds? I can't see what you posted as the error condition.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fwpf%2Fissues%2F119%23issuecomment-457288242&data=02%7C01%7C%7C94bc584684294a324a1b08d68222fcac%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636839484105588899&sdata=fihRUuSrimHsHabIzHeUo5pHO1bWVSoT%2FRr8Q6urHgM%3D&reserved=0, or mute the threadhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADWm4lRqLOsj8kbSeO1awqX_hIZfCqWyks5vGe_4gaJpZM4ZIwbZ&data=02%7C01%7C%7C94bc584684294a324a1b08d68222fcac%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636839484105588899&sdata=gHshh4pNibgxa6E%2Fr5uC1ur%2BXf9BWDRpxvSQqmv%2FKAQ%3D&reserved=0.

[rladuca]

Yep, that can be confused when multiple things with the preview moniker are in flight. Thanks for confirming!