Wp-rocket: Variable width for radio button - "My Status" section

Created on 25 Mar 2019  Â·  9Comments  Â·  Source: wp-media/wp-rocket

This is the message that one of our volunteer translators sent us:

Hi there. I'm one of the volunteer translators for wp rocket and i noticed a glitch/bug that's not strictly related to the translation itself. I translated WP Rocket to Croatian. The translation works just fine but i noticed that the checkboxes under the Status section have a fixed width so the translated text doesn't fit.
In the upper checkbox i used the abbreviation for Off in Croatian and it still doesn't fit not to mention that in the screenshot i added some padding to it so you can see the text. Otherwise, it overlaps the description.

This is a screenshot representing the issue:
radiobox fixed width

dashboard [XS] good first issue low minor bug

Most helpful comment

I think that On / OFF should be kept in all languages in order to accomodate that field. I noticed the same issue in Romanian, Turkish, Suomi, Portuguese.

All 9 comments

I think that On / OFF should be kept in all languages in order to accomodate that field. I noticed the same issue in Romanian, Turkish, Suomi, Portuguese.

@AliceOrru Is there a way to get feedback from our translators about the suggestion to use ON/OFF or YES/NO for all languages? Maybe they know how it's handled in other plugins or themes?

The tool we use to keep in touch with our translators is Transifex: I can try to send a message from there and explain the issue.
YES/NO is, in my opinion, the best solution, since it's very short in most languages (Yes/ No).

Thanks @AliceOrru. Please let us know if you hear back from the community. If not, we will decide this internally based on your feedback :)

Yes/No is quite weird, isn't it? What does it mean for an option?

  • Yes, I want it
  • Yes, I want to deactivate

When On/Off can't be confused

@GeekPress What should we do for this?

@Tabrisrp We can go with On/Off for all languages

Scope a solution ✅

In

  • view/settings/page.php
  • view/settings/one-click-addon.php
  • view/settings/rocket-addon.php
  • view/settings/sliding-checkbox.php
  • Change <?php echo esc_attr_x( 'On', 'Active state of checkbox', 'rocket' ); ?> to On
  • Change <?php echo esc_attr_x( 'Off', 'Inactive state of checkbox', 'rocket' ); ?> to Off

Estimate the effort ✅

Effort [XS]

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Tabrisrp picture Tabrisrp  Â·  4Comments

piotrbak picture piotrbak  Â·  3Comments

webtrainingwheels picture webtrainingwheels  Â·  5Comments

vmanthos picture vmanthos  Â·  5Comments

NataliaDrause picture NataliaDrause  Â·  4Comments