Wp-rocket: GLOB_BRACE is not available on all systems

Created on 5 Sep 2016 · 27Comments · Source: wp-media/wp-rocket

Most notably it's not supported on Solaris and Alpine (a quite popular lightweight linux distribution used mostly for running docker containers), so it's throwing a PHP notice

@GeekPress what do you think about this?

cache high moderate bug

Source

Tabrisrp

👍1

Most helpful comment

@NataliaDrause @jorgemartine00 Thanks for the submissions. FYI, in case you wish to tease the customers, this is planned for 3.8.2. 🚀

arunbasillal on 28 Dec 2020

🚀2 👍1

All 27 comments

glob cost a lot in ressource. Not sure to implement a double glob will be great. How much time did we have this issue?

GeekPress on 7 Sep 2016

First time I think

Tabrisrp on 7 Sep 2016

It seems to be an exotic issue

GeekPress on 10 Sep 2016

SunOS could be another one.
https://secure.helpscout.net/conversation/269503186/25314/?folderId=714999

glueckpress on 27 Oct 2016

❗️ @Tabrisrp / @GeekPress FYI: According to a recent reply to the ticket from my previous comment, the error occurs on a regular shared web hosting environment of a major German web host: STRATO.

Update: Customer assumes STRATO uses SunOS only on older servers, but still a show stopper for clients hosted on those.

glueckpress on 28 Oct 2016

Another ticket here:
https://secure.helpscout.net/conversation/967731643/124733/

They are on Strato.

vmanthos on 29 Sep 2019

Hi,
any progress on this?
we are running on Alpine and also encounter issues with it.

Warning: Use of undefined constant GLOB_BRACE - assumed 'GLOB_BRACE'
plugins/wp-rocket/inc/functions/files.php in rocket_clean_home

```PHP
// Delete homepage.
$files = glob( $root . '/{index,index-*}.{html,html_gzip}', GLOB_BRACE | GLOB_NOSORT );

Warning: Use of undefined constant GLOB_BRACE - assumed 'GLOB_BRACE'
plugins/wp-rocket/inc/functions/files.php in rocket_clean_home at line 719

```PHP
// Remove the hidden empty file for mobile detection on NGINX with the Rocket NGINX configuration.
$nginx_mobile_detect_files = glob( $root . '/.mobile-active', GLOB_BRACE | GLOB_NOSORT );

Thanks

bainternet on 31 Mar 2020

Some problem on Alpine.

mabezdek on 4 May 2020

There's just one more instance of glob() in Rocket's code base. It's in inc/main.php in the rocket_deactivation function found here.

This is a good first contribution for our newest software dev @iCaspar . Once a PR is merged for this last instance of glob(), we can close this issue.

hellofromtonya on 10 Jun 2020

Turns out, we're still using glob() in several more places:
In files.php Lines

660
668
676
948
983
Also, one reference in the tests (Integration/.../Engine/Cache/PurgeActionsSubscrber) that a workaround was used for vfs incompatibility with glob() one of those uses in files.

iCaspar on 17 Jun 2020

Related ticket (Alpine) - https://secure.helpscout.net/conversation/1292160882/197454/

Customer used this snippet to fix the issue on their end:

add_action( 'before_rocket_clean_home', 'purge_home_cache_files', 10 );
function purge_home_cache_files( $root ) {
    // Original files getter
    // $files = glob( $root . '/{index,index-*}.{html,html_gzip}', GLOB_BRACE | GLOB_NOSORT );

    $files = glob( $root . '/index-http*' );
    $files_mob = glob( $root . '/index-mobile*' );
    $files = array_merge( $files, $files_mob );

    if ( $files ) {
        foreach ( $files as $file ) {
            // Delete homepage cache files.
            rocket_direct_filesystem()->delete( $file );
        }
    }
}

DahmaniAdame on 2 Oct 2020

Need to address 3 instances of this in rocket_clean_home().

iCaspar on 2 Oct 2020

Another case: https://secure.helpscout.net/conversation/1347350243/215402

It seems that this will throw an error in future versions of PHP:

- PHP Warning: Use of undefined constant GLOB_BRACE - assumed 'GLOB_BRACE' (this will throw an Error in a future version of PHP) in /mnt/web509/b2/25/510641625/htdocs/WordPress_02/wp-content/plugins/wp-rocket/inc/functions/files.php on line 640

sandyfigueroa on 24 Nov 2020

vmanthos on 3 Dec 2020

Assigning this to milestone 3.8.1 -- with PHP8 we need to get this taken care of asap.

iCaspar on 3 Dec 2020

👍2

There are exactly 3 instances of GLOB_BRACE remaining in files.php:
L: 616, 632, 640
Of those the instances on L:632 and L:640 can be simply removed; there are no braces in the pattern to be evaluated.
On L:616, we can replace the glob with _rocket_get_recursive_dir_files($regex) where $regex replaces the braketed pattern.

Refactoring should be straightforward, but will also need to get rocket_clean_home() under test as part of the PR.

Effort: [S]

iCaspar on 3 Dec 2020

@Tabrisrp Is this safe to be included in a minor? Or will it need staggered release? (cc: @GeekPress)

If it's safe to include in a minor, lets at least plan for 3.8.2 since we hope to release 3.8.1 early next week. Iirc, changes to GLOB_BRACE created tickets in the past.

arunbasillal on 16 Dec 2020

@arunbasillal Yes, this should be fine for a minor. 3.8.2 sounds like a good timeline for it.

iCaspar on 16 Dec 2020

👍2

NataliaDrause on 28 Dec 2020

jorgemartine00 on 28 Dec 2020

@NataliaDrause @jorgemartine00 Thanks for the submissions. FYI, in case you wish to tease the customers, this is planned for 3.8.2. 🚀

arunbasillal on 28 Dec 2020

🚀2 👍1

@wp-media/php The linked PR #3436 removes the last of GLOB_BRACE per the OP on this issue. @wp-media/qa has given it an initial review, but further discussion came up about removing glob altogether, as a performance enhancement.
In the interest of getting rid of the actual problem issue, I'm in favor of getting this merged now, and saving the overall use of glob as an enhancement (we have more uses of glob without GLOB_BRACE in the codebase.)
I've opened this issue to continue that discussion in order to unblock this and get it finally into the 3.8.2 release as it directly affects customers.