Wp-graphql: TODO: add tests for PHP 5.6+ support

Created on 3 Nov 2019  路  4Comments  路  Source: wp-graphql/wp-graphql

There used to be tests for PHP 5.6 and up but they were removed. Since we support 5.6+ for now we should write tests for this.

Tests
Source
picture TylerBarnes

Most helpful comment

I believe @jasonbahl wanted to commit to keeping support in line with WP. Maybe we could do it as TDD, write the tests and then change incompatible code until the tests pass.

picture TylerBarnes on 4 Nov 2019
👍2

All 4 comments

This will help with https://github.com/wp-graphql/wp-graphql/issues/865

TylerBarnes picture TylerBarnes on 3 Nov 2019

This needs a bit more discussion. The code specifically isn't compatible with PHP 5.6.

kidunot89 picture kidunot89 on 4 Nov 2019
👍1

I believe @jasonbahl wanted to commit to keeping support in line with WP. Maybe we could do it as TDD, write the tests and then change incompatible code until the tests pass.

TylerBarnes picture TylerBarnes on 4 Nov 2019
👍2

Closing as we are going to support 7.0+

jasonbahl picture jasonbahl on 13 Dec 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

moonmeister picture moonmeister  路  4Comments
cr101 picture cr101  路  3Comments
CalebBarnes picture CalebBarnes  路  4Comments
jasonbahl picture jasonbahl  路  4Comments
reallyfabdigital picture reallyfabdigital  路  3Comments